[Django] #37046: PR Quality check may need to account for ready for check-in

[Django]

#37046: PR Quality check may need to account for ready for check-in
--------------------------------+-----------------------------------------
Reporter: Tim Schilling | Type: Bug
Status: new | Component: Uncategorized
Version: dev | Severity: Normal
Keywords: GitHub Actions | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+-----------------------------------------
This is in reference to
[https://github.com/django/django/pull/21041#issuecomment-4272913765 PR
21041]

I reviewed @Afenomamy's PR and it looks ready to go. According to the
[https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#ready-for-checkin contribution docs], I'm supposed to mark it as
ready for check-in. I did so, but then it was flagged by the bot.
Reviewing the code for
[https://github.com/django/django/blob/main/scripts/pr_quality/check_pr.py
check_pr.py], there isn't an exception for this state. I suspect there
should be.
--
Ticket URL: <https://code.djangoproject.com/ticket/37046>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#37046: PR Quality check may need to account for ready for check-in

---------------------------------+------------------------------------
Reporter: Tim Schilling | Owner: (none)

Type: Bug | Status: new
Component: Uncategorized | Version: dev

Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+------------------------------------
Changes (by Jacob Walls):

* cc: Natalia Bidart (added)
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:1>

[Django]

#37046: PR Quality check may need to account for ready for check-in
---------------------------------+------------------------------------
Reporter: Tim Schilling | Owner: (none)
Type: Bug | Status: new

Component: Core (Other) | Version: dev

Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Jacob Walls):

* component: Uncategorized => Core (Other)

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:2>

[Django]

#37046: PR Quality check may need to account for ready for check-in

-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned

Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Varun Kasyap Pentamaraju):

* owner: (none) => Varun Kasyap Pentamaraju
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:3>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Varun Kasyap Pentamaraju):

* has_patch: 0 => 1

Comment:

https://github.com/django/django/pull/21129
--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:4>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by JaeHyuckSa):

* cc: Natalia Bidart (removed)
* cc: JaeHyuckSa (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:5>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JaeHyuckSa):

* cc: Natalia, Bidart (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:6>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JaeHyuckSa):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:7>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JaeHyuckSa):

* cc: Natalia, Bidart (removed)
* cc: natalia (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:8>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by JaeHyuckSa):

Sorry, I keep messing up the CC field.
--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:9>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by JaeHyuckSa):

* cc: natalia (removed)

* cc: Natalia Bidart (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:10>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls):

If not self-evident, there are a couple places where more actions happen
after marking a ticket RFC that will re-trigger the action:
- merger wants to trigger more tests, so they apply the Selenium or
coverage labels
- author pushes again to add themselves to AUTHORS
- merger force-pushes to edit commit messages etc.
--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:11>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Release blocker | Resolution:
Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Varun Kasyap Pentamaraju):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:12>

[Django]

#37046: PR Quality check may need to account for ready for check-in
-------------------------------------+-------------------------------------
Reporter: Tim Schilling | Owner: Varun
| Kasyap Pentamaraju

Type: Bug | Status: closed

Component: Core (Other) | Version: dev

Severity: Release blocker | Resolution: fixed

Keywords: GitHub Actions | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"673fa46d8063577c92cfab3a73a28e9406372e33" 673fa46d]:
{{{#!CommitTicketReference repository=""
revision="673fa46d8063577c92cfab3a73a28e9406372e33"
Fixed #37046 -- Allowed Ready for checkin Trac status in PR checks.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/37046#comment:13>