[Django] #28991: Add new BlankFieldListFilter admin filter
Django
-----------------------------------------+------------------------
Reporter: Jonas Haag | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Add a new admin filter that allows to show only objects with a blank (or
non-blank) field value. Shows three options "all", "blank", "not blank".
This is something I've regularly required and there doesn't seem to be any
third party package implementing this, but there are at least a few other
people having the need: https://stackoverflow.com/questions/37799694
/django-admin-list-filter-filter-field-by-is-empty-none-or-empty-string
https://gist.github.com/haplo/2695675 Note that while the filter could
easily live in a third party package, I think it makes sense to include it
in Django. It's not much code and I guess it's a common requirement.
--
Ticket URL: <https://code.djangoproject.com/ticket/28991>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Jonas Haag | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Jonas Haag):
PR https://github.com/django/django/pull/9546
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:1>
Django
Reporter: Jonas Haag | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
Duplicate of #28687?
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:2>
Django
Reporter: Jonas Haag | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Jonas Haag):
Not exactly here we're looking at
- a new filter for
- blank values
- of any kind of field (not necessarily relation fields)
#28687 is looking at
- an extension of an existing filter
- of null values
- that deals with relation fields
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:3>
Django
-------------------------------+------------------------------------
Reporter: Jonas Haag | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_docs: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:4>
Django
-------------------------------+------------------------------------
Reporter: Jonas Haag | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Christophe Baldy):
Hi,
I tried to rework and improve and the original PR with my own PR
[https://github.com/django/django/pull/10599]
(This my first attempt to contribute to Django)
Thanks
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:5>
Django
-------------------------------+---------------------------------------
Reporter: Jonas Haag | Owner: Basil Dubyk
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Basil Dubyk):
* owner: nobody => Basil Dubyk
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:6>
Django
-------------------------------+------------------------------------
Type: New feature | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Basil Dubyk):
* owner: Basil Dubyk => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:7>
Django
-------------------------------+------------------------------------
Reporter: Jonas Haag | Owner: (none)
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette):
* needs_docs: 1 => 0
* needs_better_patch: 0 => 1
Comment:
Left a few comments for improvements on the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:8>
Django
-------------------------------+------------------------------------
Reporter: Jonas Haag | Owner: (none)
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Christophe Baldy):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:9>
Django
-------------------------------+------------------------------------
Reporter: Jonas Haag | Owner: (none)
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* needs_better_patch: 0 => 1
Comment:
Commented on PR: Docs need some clarification. Possibly some extra tests
needed. (?) Needs updating to target v3.0.
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Jonas Haag | Owner: Federico
| Jaramillo Martínez
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by Federico Jaramillo Martínez):
* owner: (none) => Federico Jaramillo Martínez
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Jonas Haag | Owner: Federico
| Jaramillo Martínez
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Federico Jaramillo Martínez):
* needs_better_patch: 1 => 0
Comment:
PR https://github.com/django/django/pull/12239
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Jonas Haag | Owner: Federico
| Jaramillo Martínez
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: Jonas Haag | Owner: Federico
| Jaramillo Martínez
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"372eaa395f167c038e546c6be554c96014d40109" 372eaa39]:
{{{
#!CommitTicketReference repository=""
revision="372eaa395f167c038e546c6be554c96014d40109"
Fixed #28991 -- Added EmptyFieldListFilter class in admin.filters.
Thanks Simon Charette and Carlton Gibson for reviews.
Co-Authored-By: Jonas Haag <jo...@lophus.org>
Co-Authored-By: Christophe Baldy <christop...@polyconseil.fr>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28991#comment:14>