Re: [Django] #34688: Remove contrib.sitemaps.ping_google().

6 views
Skip to first unread message

Django

unread,
Jul 8, 2023, 10:32:39 AM7/8/23
to django-...@googlegroups.com
#34688: Remove contrib.sitemaps.ping_google().
-------------------------------------+-------------------------------------
Reporter: Andrew Northall | Owner: Andrew
Type: | Northall
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Andrew Northall):

* needs_better_patch: 1 => 0


Comment:

PR updated to fully remove `contrib.sitemaps.ping_google()` and the
`ping_google` management command without prior deprecation as per
consensus on the Django forum.

--
Ticket URL: <https://code.djangoproject.com/ticket/34688#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 10, 2023, 12:00:19 AM7/10/23
to django-...@googlegroups.com
#34688: Remove contrib.sitemaps.ping_google().
-------------------------------------+-------------------------------------
Reporter: Andrew Northall | Owner: Andrew
Type: | Northall
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34688#comment:7>

Django

unread,
Jul 10, 2023, 1:46:07 AM7/10/23
to django-...@googlegroups.com
#34688: Remove contrib.sitemaps.ping_google().
-------------------------------------+-------------------------------------
Reporter: Andrew Northall | Owner: Andrew
Type: | Northall
Cleanup/optimization | Status: closed
Component: contrib.sitemaps | Version: 4.2
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6d427288e410e9cad39b1aa1b4d4893fbd391282" 6d42728]:
{{{
#!CommitTicketReference repository=""
revision="6d427288e410e9cad39b1aa1b4d4893fbd391282"
Fixed #34688 -- Removed contrib.sitemaps.ping_google() and ping_google
management command.

Thanks Joachim Jablon for the report.

Google has deprecated the sitemap ping endpoint, and will be removing
it in 6 months ~January 2024.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34688#comment:8>

Reply all
Reply to author
Forward
0 new messages