[Django] #26929: Deprecate `extra_context` parameter in `contrib.auth.views.logout_then_login`

16 views
Skip to first unread message

Django

unread,
Jul 22, 2016, 10:41:01 AM7/22/16
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
--------------------------------------+-----------------
Reporter: andrewnester | Owner:
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version:
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+-----------------
Using extra context makes sense when we are rendering some template but
with `logout_then_login` we just have HttpRedirectResponse returned with
no context data.

--
Ticket URL: <https://code.djangoproject.com/ticket/26929>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 22, 2016, 10:41:08 AM7/22/16
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
-------------------------------------+-------------------------------------
Reporter: andrewnester | Owner:
Type: | andrewnester
Cleanup/optimization | Status: assigned
Component: Uncategorized | Version:
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by andrewnester):

* status: new => assigned
* needs_better_patch: => 0
* owner: => andrewnester
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26929#comment:1>

Django

unread,
Jul 22, 2016, 10:46:32 AM7/22/16
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
-------------------------------------+-------------------------------------
Reporter: andrewnester | Owner:
Type: | andrewnester
Cleanup/optimization | Status: assigned
Component: Uncategorized | Version:
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by andrewnester):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/26929#comment:2>

Django

unread,
Jul 22, 2016, 12:14:08 PM7/22/16
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
-------------------------------------+-------------------------------------
Reporter: andrewnester | Owner:
Type: | andrewnester
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* version: => master
* component: Uncategorized => contrib.auth
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/6944 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26929#comment:3>

Django

unread,
Jul 22, 2016, 4:48:45 PM7/22/16
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
-------------------------------------+-------------------------------------
Reporter: andrewnester | Owner:
Type: | andrewnester
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

Left comments for improvement on the PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/26929#comment:4>

Django

unread,
Jul 28, 2016, 12:01:33 PM7/28/16
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
-------------------------------------+-------------------------------------
Reporter: andrewnester | Owner:
Type: | andrewnester
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"0ba179194bc261f49b04a5eac85322b56a537e45" 0ba17919]:
{{{
#!CommitTicketReference repository=""
revision="0ba179194bc261f49b04a5eac85322b56a537e45"
Fixed #26929 -- Deprecated extra_context parameter of
contrib.auth.views.logout_then_login().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26929#comment:5>

Django

unread,
Sep 22, 2017, 1:39:41 PM9/22/17
to django-...@googlegroups.com
#26929: Deprecate `extra_context` parameter in
`contrib.auth.views.logout_then_login`
-------------------------------------+-------------------------------------
Reporter: Andrew Nester | Owner: Andrew
Type: | Nester

Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"6e40b70bf4c6e475266a9f011269c50f29f0f14e" 6e40b70b]:
{{{
#!CommitTicketReference repository=""
revision="6e40b70bf4c6e475266a9f011269c50f29f0f14e"
Refs #26929 -- Removed extra_context parameter of
contrib.auth.views.logout_then_login().

Per deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26929#comment:6>

Reply all
Reply to author
Forward
0 new messages