[Django] #33224: BaseDatabaseFeatures.supports_mixed_date_datetime_comparisons comment references defunct date_interval_sql

1 view
Skip to first unread message

Django

unread,
Oct 23, 2021, 7:34:55 PM10/23/21
to django-...@googlegroups.com
#33224: BaseDatabaseFeatures.supports_mixed_date_datetime_comparisons comment
references defunct date_interval_sql
-------------------------------------+-------------------------------------
Reporter: Tim | Owner: nobody
Graham |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: dev
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
[https://github.com/django/django/blob/551c997feaaa293987af8b05efc3634b93305fac/django/db/backends/base/features.py#L115
The comment] says "date_interval_sql can properly handle mixed
Date/DateTime fields and timedeltas" but date_interval_sql was removed in
dd5aa8cb5ffc0a89c4b9b8dee45c1c919d203489.

--
Ticket URL: <https://code.djangoproject.com/ticket/33224>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 25, 2021, 12:24:12 AM10/25/21
to django-...@googlegroups.com
#33224: BaseDatabaseFeatures.supports_mixed_date_datetime_comparisons comment
references defunct date_interval_sql
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

Thanks. Yes, this comment should be updated.

--
Ticket URL: <https://code.djangoproject.com/ticket/33224#comment:1>

Django

unread,
Oct 27, 2021, 11:18:48 AM10/27/21
to django-...@googlegroups.com
#33224: BaseDatabaseFeatures.supports_mixed_date_datetime_comparisons comment
references defunct date_interval_sql
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned

Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* owner: nobody => Hasan Ramezani
* status: new => assigned
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/15027 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33224#comment:2>

Django

unread,
Nov 2, 2021, 2:33:19 AM11/2/21
to django-...@googlegroups.com
#33224: BaseDatabaseFeatures.supports_mixed_date_datetime_comparisons comment
references defunct date_interval_sql
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33224#comment:3>

Django

unread,
Nov 2, 2021, 3:09:22 PM11/2/21
to django-...@googlegroups.com
#33224: BaseDatabaseFeatures.supports_mixed_date_datetime_comparisons comment
references defunct date_interval_sql
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed

Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: assigned => closed
* resolution: => fixed


Comment:

Fixed in
[https://github.com/django/django/commit/c069ee0b9dd823899bd7095deadf167cd426c0b7
c069ee0b9dd823899bd7095deadf167cd426c0b7].

--
Ticket URL: <https://code.djangoproject.com/ticket/33224#comment:4>

Reply all
Reply to author
Forward
0 new messages