[Django] #17210: Make NullBooleanSelect for NullBooleanField pass true/false as a GET parameter
Django
parameter
-------------------------------------------------+--------------------
Reporter: anatoly techtonik <techtonik@…> | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------------------+--------------------
Currently, NullBooleanSelect uses form with the following parameters:
{{{
choices = ((u'1', ugettext('Unknown')), (u'2', ugettext('Yes')), (u'3',
ugettext('No')))
}}}
which generates URLs like `?param=3` for `Param: No` selection and
`?param=1` for `Param: Unknown`. This makes URLs pretty counter-intuitive
for search forms. For example, imaging search for issues. If you need to
find all closed issues, the URL will be `?closed=3`, not `?closed=1` as
you may assume for boolean field.
It will be more user-friendly to generate `param=`, `param=true` and
`param=false` for boolean field URLs.
--
Ticket URL: <https://code.djangoproject.com/ticket/17210>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
parameter
Reporter: anatoly techtonik | Owner: nobody
<techtonik@…> | Status: new
Type: | Version: SVN
Cleanup/optimization | Resolution:
Component: Forms | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 0 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* needs_better_patch: => 0
* needs_tests: => 0
* version: 1.2 => SVN
* needs_docs: => 0
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
I'm accepting the idea on principle, but I'd like to see a thorough
analysis of how much backwards-incompatibility this change introduces.
--
Ticket URL: <https://code.djangoproject.com/ticket/17210#comment:1>
Django
parameter
Reporter: anatoly techtonik | Owner: Basil
<techtonik@…> | Dubyk
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Basil Dubyk):
* owner: nobody => Basil Dubyk
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/17210#comment:2>
Django
parameter
Reporter: anatoly techtonik | Owner: Basil
<techtonik@…> | Dubyk
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Basil Dubyk):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/10630 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/17210#comment:3>
Django
parameter
Reporter: anatoly techtonik | Owner: Basil
<techtonik@…> | Dubyk
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/17210#comment:4>
Django
parameter
Reporter: anatoly techtonik | Owner: Basil
<techtonik@…> | Dubyk
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Basil Dubyk):
* needs_better_patch: 1 => 0
Comment:
PR updated. Tim Graham many thanks for comments.
--
Ticket URL: <https://code.djangoproject.com/ticket/17210#comment:5>
Django
parameter
Reporter: anatoly techtonik | Owner: Basil
<techtonik@…> | Dubyk
Cleanup/optimization |
Component: Forms | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"35a08b8541c856a51b2ab718e0a2fe060debfa2a" 35a08b85]:
{{{
#!CommitTicketReference repository=""
revision="35a08b8541c856a51b2ab718e0a2fe060debfa2a"
Fixed #17210 -- Made NullBooleanSelect use unknown/true/false as query
data.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17210#comment:6>