[Django] #36578: Visual regression in inline delete button size

9 views
Skip to first unread message

Django

unread,
Aug 28, 2025, 7:22:53 AM (11 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
-----------------------------+-------------------------------------------
Reporter: Sarah Boyce | Type: Bug
Status: new | Component: contrib.admin
Version: dev | Severity: Release blocker
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+-------------------------------------------
In 5.2, the inline delete button was made bigger for accessibility reasons
(see #35791)

This has regressed since 87ab54b488cb58d810939112f208bb37068710e0 (#35829)

(I will attach screenshots shortly)
--
Ticket URL: <https://code.djangoproject.com/ticket/36578>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 28, 2025, 7:24:53 AM (11 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+--------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* Attachment "image-20250828-132446.png" added.

Django

unread,
Aug 28, 2025, 7:26:24 AM (11 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+--------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* Attachment "image-20250828-132618.png" added.

Django

unread,
Aug 28, 2025, 7:26:49 AM (11 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+--------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Description changed by Sarah Boyce:

Old description:

> In 5.2, the inline delete button was made bigger for accessibility
> reasons (see #35791)
>
> This has regressed since 87ab54b488cb58d810939112f208bb37068710e0
> (#35829)
>
> (I will attach screenshots shortly)

New description:

In 5.2, the inline delete button was made bigger for accessibility reasons
(see #35791)

[[Image(image-20250828-132618.png​)]]

This has regressed since 87ab54b488cb58d810939112f208bb37068710e0 (#35829)

[[Image(image-20250828-132446.png​)]]

--
--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:1>

Django

unread,
Aug 28, 2025, 9:11:05 AM (10 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* has_patch: 0 => 1
* owner: (none) => Sarah Boyce
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:2>

Django

unread,
Aug 28, 2025, 9:39:17 AM (10 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted

Comment:

Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:3>

Django

unread,
Aug 28, 2025, 1:20:33 PM (10 days ago) Aug 28
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Natalia Bidart):

* needs_better_patch: 0 => 1
* ui_ux: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:4>

Django

unread,
Aug 29, 2025, 8:52:48 AM (9 days ago) Aug 29
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:5>

Django

unread,
Sep 4, 2025, 9:03:37 AM (3 days ago) Sep 4
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:6>

Django

unread,
Sep 4, 2025, 12:36:14 PM (3 days ago) Sep 4
to django-...@googlegroups.com
#36578: Visual regression in inline delete button size
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"c595af65457e44221aa56cab25e1b5766d802b8f" c595af6]:
{{{#!CommitTicketReference repository=""
revision="c595af65457e44221aa56cab25e1b5766d802b8f"
Fixed #36578, Refs #35791 -- Ensured inline delete icon scales and stays
centered in the admin.

Regression in 87ab54b488cb58d810939112f208bb37068710e0. Refs #35829.

Thank you Natalia Bidart for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36578#comment:7>
Reply all
Reply to author
Forward
0 new messages