[Django] #25336: activate current language when clicking view_on_site button in Django Post admin page

2 views
Skip to first unread message

Django

unread,
Sep 2, 2015, 3:37:17 AM9/2/15
to django-...@googlegroups.com
#25336: activate current language when clicking view_on_site button in Django Post
admin page
-------------------------+-------------------------------------------------
Reporter: zoe- | Owner: nobody
stockholm |
Type: Bug | Status: new
Component: | Version: 1.7
contrib.admin | Keywords: multiple languages, post admin,
Severity: Normal | view on site
Triage Stage: | Has patch: 0
Unreviewed |
Easy pickings: 0 | UI/UX: 0
-------------------------+-------------------------------------------------
The issue is in single post admin page, when the post has multi-language,
the view_on_site button always navigate to the default language no matter
what language the obj is using. The solution is simple to activate the
current language and create a url with current language code instead of
default language always.

--
Ticket URL: <https://code.djangoproject.com/ticket/25336>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 2, 2015, 3:41:57 AM9/2/15
to django-...@googlegroups.com
#25336: activate current language when clicking view_on_site button in Django Post
admin page
-------------------------------------------------+-------------------------
Reporter: zoe-stockholm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution:
Keywords: multiple languages, post admin, | Triage Stage:
view on site | Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------------+-------------------------
Changes (by zoe-stockholm):

* Attachment "options.py" added.

the solution is between line 273-278

Django

unread,
Sep 2, 2015, 3:58:59 AM9/2/15
to django-...@googlegroups.com
#25336: activate current language when clicking view_on_site button in Django Post
admin page
-------------------------------------+-------------------------------------
Reporter: zoe-stockholm | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution:
Keywords: multiple languages, | Triage Stage:
post admin, view on site | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by zoe-stockholm):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25336#comment:1>

Django

unread,
Sep 2, 2015, 4:04:16 AM9/2/15
to django-...@googlegroups.com
#25336: activate current language when clicking view_on_site button in Django Post
admin page
-------------------------------------+-------------------------------------
Reporter: zoe-stockholm | Owner: zoe-
| stockholm
Type: Bug | Status: assigned

Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution:
Keywords: multiple languages, | Triage Stage:
post admin, view on site | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by zoe-stockholm):

* owner: nobody => zoe-stockholm
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/25336#comment:2>

Django

unread,
Sep 2, 2015, 4:05:13 AM9/2/15
to django-...@googlegroups.com
#25336: activate current language when clicking view_on_site button in Django Post
admin page
-------------------------------------+-------------------------------------
Reporter: zoe-stockholm | Owner: zoe-
| stockholm
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: fixed

Keywords: multiple languages, | Triage Stage:
post admin, view on site | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by zoe-stockholm):

* status: assigned => closed
* resolution: => fixed


--
Ticket URL: <https://code.djangoproject.com/ticket/25336#comment:3>

Django

unread,
Sep 2, 2015, 9:06:21 AM9/2/15
to django-...@googlegroups.com
#25336: activate current language when clicking view_on_site button in Django Post
admin page
-------------------------------------+-------------------------------------
Reporter: zoe-stockholm | Owner: zoe-
| stockholm
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: wontfix

Keywords: multiple languages, | Triage Stage:
post admin, view on site | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* resolution: fixed => wontfix


Comment:

As discussed on the [https://github.com/django/django/pull/5147 pull
request]. It's not clear to me that this can't be solved in a custom
`get_absolute_url()` method. Assuming that the model instance has a
`language_code` doesn't seem like a good idea. Please reopen with more
details if you find that it can't be solved without making a change to
Django. Thanks!

--
Ticket URL: <https://code.djangoproject.com/ticket/25336#comment:4>

Reply all
Reply to author
Forward
0 new messages