[Django] #25895: Customizing user admin docs shouldn't override name.
Django
-------------------------------+--------------------
Reporter: justinabrahms | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
https://github.com/django/django/blob/master/docs/topics/auth/customizing.txt#L342
In the above documentation, we're inheriting from `UserAdmin` while
renaming our own class `UserAdmin`. Instead, we should rename one of the
two of those so it is more clear (and generally doesn't throw pylint
errors).
--
Ticket URL: <https://code.djangoproject.com/ticket/25895>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: justinabrahms | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* needs_better_patch: => 0
* needs_tests: => 0
* version: 1.9 => master
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:1>
Django
Reporter: justinabrahms | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* Attachment "25895.diff" added.
Django
Reporter: justinabrahms | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
Comment:
I think `import UserAdmin as BaseUserAdmin` is an okay way to go. Any
preferences?
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:2>
Django
Reporter: justinabrahms | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by justinabrahms):
Sounds good to me. +1 on change. :)
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:3>
Django
Reporter: justinabrahms | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* stage: Accepted => Ready for checkin
Comment:
In release notes, you can let one of MyUserAdmin / BaseUserAdmin as
UserAdmin.
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:4>
Django
Reporter: justinabrahms | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"166e0490d39f619928ee9c5133cc5cab0ae5c1db" 166e0490]:
{{{
#!CommitTicketReference repository=""
revision="166e0490d39f619928ee9c5133cc5cab0ae5c1db"
Fixed #25895 -- Used a consistent style for UserAdmin overrides.
Thanks Justin Abrahms for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:5>
Django
Reporter: justinabrahms | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"abeb50db5dbc9e5b08c2974d39c1f92e0c051c1c" abeb50db]:
{{{
#!CommitTicketReference repository=""
revision="abeb50db5dbc9e5b08c2974d39c1f92e0c051c1c"
[1.9.x] Fixed #25895 -- Used a consistent style for UserAdmin overrides.
Thanks Justin Abrahms for the report.
Backport of 166e0490d39f619928ee9c5133cc5cab0ae5c1db from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:6>
Django
Reporter: justinabrahms | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"cdc354eb39085bb03f90216509611c279bf368f5" cdc354e]:
{{{
#!CommitTicketReference repository=""
revision="cdc354eb39085bb03f90216509611c279bf368f5"
[1.8.x] Fixed #25895 -- Used a consistent style for UserAdmin overrides.
Thanks Justin Abrahms for the report.
Backport of 166e0490d39f619928ee9c5133cc5cab0ae5c1db from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25895#comment:7>