[Django] #32391: Replace width with flex properties for the changelist filter
Django
-------------------------------------+-------------------------------------
Reporter: Denis | Owner: nobody
Skulimovskiy |
Type: Bug | Status: new
Component: | Version: 3.1
Uncategorized |
Severity: Normal | Keywords: changelist, css
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
Hi there,
I've found a CSS bug in the Django admin. When the left-side container
becomes too wide, the filters become squashed. That's because the flex-
grow/shrink/basis values aren't set for the filter.
I suggest replacing the width value with flex-basis and set flex-
grow/shrink props to 0.
I'll try to create a pull request for this fix.
Thanks,
Denis
--
Ticket URL: <https://code.djangoproject.com/ticket/32391>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Denis Skulimovskiy | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 3.1
Severity: Normal | Resolution:
Keywords: changelist, css | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Comment (by Denis Skulimovskiy):
Pull request: https://github.com/django/django/pull/13941
--
Ticket URL: <https://code.djangoproject.com/ticket/32391#comment:1>
Django
Reporter: Denis Skulimovskiy | Owner: nobody
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: changelist, css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Carlton Gibson):
* component: Uncategorized => contrib.admin
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Comment:
OK, initial glance looks right. (I need to test more fully but...)
I think we can take this as a bug in the new sidebar feature for Django
3.1.
--
Ticket URL: <https://code.djangoproject.com/ticket/32391#comment:2>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32391#comment:3>
Django
-------------------------------------+-------------------------------------
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: changelist, css | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"269a76714616fd7ad166a14113f3354bab8d9b65" 269a7671]:
{{{
#!CommitTicketReference repository=""
revision="269a76714616fd7ad166a14113f3354bab8d9b65"
Fixed #32391 -- Used CSS flex properties for changelist filter.
Matched layout adjustment using flex from admin sidebar added in
d24ba1be7a53a113d19e2860c03aff9922efec24.
Filters would become squashed when viewport was
constrained or list display table became too wide.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32391#comment:4>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: changelist, css | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"d83249b0b9e516470c29278321ad77f6b087ed97" d83249b0]:
{{{
#!CommitTicketReference repository=""
revision="d83249b0b9e516470c29278321ad77f6b087ed97"
[3.2.x] Fixed #32391 -- Used CSS flex properties for changelist filter.
Matched layout adjustment using flex from admin sidebar added in
d24ba1be7a53a113d19e2860c03aff9922efec24.
Filters would become squashed when viewport was
constrained or list display table became too wide.
Backport of 269a76714616fd7ad166a14113f3354bab8d9b65 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32391#comment:5>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: changelist, css | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"82e1294602abd9d85fed114380bf81538c8b6f9e" 82e1294]:
{{{
#!CommitTicketReference repository=""
revision="82e1294602abd9d85fed114380bf81538c8b6f9e"
[3.1.x] Fixed #32391 -- Used CSS flex properties for changelist filter.
Matched layout adjustment using flex from admin sidebar added in
d24ba1be7a53a113d19e2860c03aff9922efec24.
Filters would become squashed when viewport was
constrained or list display table became too wide.
Backport of 269a76714616fd7ad166a14113f3354bab8d9b65 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32391#comment:6>