[Django] #25589: startapp command should support unicode name
Django
--------------------------------+--------------------
Reporter: sih4sing5hong5 | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------
In python3, variable/package/filename is ok with begining with Unicode
character.
But the `startapp` command cannot do that.
python manage.py startapp 維護團隊
CommandError: '維護團隊' is not a valid app name. Please make sure the
name begins with a letter or underscore.
--
Ticket URL: <https://code.djangoproject.com/ticket/25589>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: sih4sing5hong5 | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* needs_better_patch: => 0
* component: Uncategorized => Internationalization
* needs_tests: => 0
* version: 1.8 => master
* needs_docs: => 0
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
Comment:
I think we should indeed follow Python policy. See also
[https://www.python.org/dev/peps/pep-3131/ PEP 3131].
Could you investigate about existing validators for such identifiers?
--
Ticket URL: <https://code.djangoproject.com/ticket/25589#comment:1>
Django
Reporter: sih4sing5hong5 | Owner: yoongkang
Type: New feature | Status: assigned
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by yoongkang):
* owner: nobody => yoongkang
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/25589#comment:2>
Django
Reporter: sih4sing5hong5 | Owner: yoongkang
Type: New feature | Status: assigned
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25589#comment:3>
Django
Reporter: sih4sing5hong5 | Owner: yoongkang
Component: | Version: master
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"3f300efede9f9670f4c413ff85ad731def15992b" 3f300efe]:
{{{
#!CommitTicketReference repository=""
revision="3f300efede9f9670f4c413ff85ad731def15992b"
Fixed #25589 -- Allowed startapp/project to create apps with Unicode
characters in the name.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25589#comment:4>
Django
Reporter: sih4sing5hong5 | Owner: yoongkang
Type: New feature | Status: closed
Component: | Version: master
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"89359347c4e7be123dd99d13a43d75e8610ae1dc" 8935934]:
{{{
#!CommitTicketReference repository=""
revision="89359347c4e7be123dd99d13a43d75e8610ae1dc"
Refs #25589 -- Fixed admin_scripts test failure on Windows.
Traceback (most recent call last):
File "tests\admin_scripts\tests.py", line 646, in
test_startapp_unicode_name
content = f.read()
File "lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 46:
character maps to <undefined>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25589#comment:5>