[Django] #31183: Add a feature flag for "PostgreSQL only supports UNBOUNDED together with PRECEDING and FOLLOWING"

5 views
Skip to first unread message

Django

unread,
Jan 19, 2020, 6:30:25 PM1/19/20
to django-...@googlegroups.com
#31183: Add a feature flag for "PostgreSQL only supports UNBOUNDED together with
PRECEDING and FOLLOWING"
-------------------------------------+-------------------------------------
Reporter: Tim | Owner: nobody
Graham |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
The Django tests for the "PostgreSQL only supports UNBOUNDED together with
PRECEDING and FOLLOWING." error are PostgreSQL specific, however, this
restriction also applies to CockroachDB. Therefore, it would be nice to
have a feature flag to control whether or not those tests are run (rather
than a `connection.vendor` check) as well as not to hardcode "PostgreSQL"
in the error message. The [https://github.com/cockroachdb/django-
cockroachdb/ CockroachDB backend] subclasses the PostgreSQL backend.

--
Ticket URL: <https://code.djangoproject.com/ticket/31183>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 19, 2020, 7:06:39 PM1/19/20
to django-...@googlegroups.com
#31183: Add a feature flag for "PostgreSQL only supports UNBOUNDED together with
PRECEDING and FOLLOWING"
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/12345 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31183#comment:1>

Django

unread,
Jan 20, 2020, 12:10:07 AM1/20/20
to django-...@googlegroups.com
#31183: Add a feature flag for "PostgreSQL only supports UNBOUNDED together with
PRECEDING and FOLLOWING"
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31183#comment:2>

Django

unread,
Jan 20, 2020, 2:26:54 PM1/20/20
to django-...@googlegroups.com
#31183: Add a feature flag for "PostgreSQL only supports UNBOUNDED together with
PRECEDING and FOLLOWING"
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"227d0c7365cfd0a64d021cb9bdcf77bed2d3f170" 227d0c73]:
{{{
#!CommitTicketReference repository=""
revision="227d0c7365cfd0a64d021cb9bdcf77bed2d3f170"
Fixed #31183 -- Added a feature flag for "<db> only supports UNBOUNDED
together with PRECEDING and FOLLOWING".
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31183#comment:3>

Reply all
Reply to author
Forward
0 new messages