Re: [Django] #34026: WKBReader.read() crashes on strings.
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Comment (by Benoît Vinot):
Thanks. Do you want me to create a PR?
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Comment (by Leo Tom):
Replying to [comment:4 Benoît Vinot]:
> Thanks. Do you want me to create a PR?
Can I claim and work on this issue ?
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:5>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:4 Benoît Vinot]:
> Thanks. Do you want me to create a PR?
Please do, thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:6>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Comment (by Benoît Vinot):
Replying to [comment:5 Leo Tom]:
> Replying to [comment:4 Benoît Vinot]:
> > Thanks. Do you want me to create a PR?
> Can I claim and work on this issue ?
Yes, if you want. :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:7>
Django
------------------------------+------------------------------------
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
* owner: nobody => Leo Tom
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:8>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: Leo Tom
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Changes (by Leo Tom):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:9>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: Leo Tom
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Comment (by Leo Tom):
PR: https://github.com/django/django/pull/16083
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:10>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: Leo Tom
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
* needs_tests: 0 => 1
Comment:
Please uncheck "Needs tests" when you add one to the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:11>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: Leo Tom
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Comment (by Leo Tom):
Replying to [comment:11 Tim Graham]:
> Please uncheck "Needs tests" when you add one to the PR.
I just have to write a test in
django/tests/gis_tests/geos_tests/test_io.py right. So all I have to do is
inside the test03_wkbreader function add a string as well right?
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:12>
Django
------------------------------+------------------------------------
Reporter: Benoît Vinot | Owner: Leo Tom
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:13>
Django
Reporter: Benoît Vinot | Owner: Leo Tom
Type: Bug | Status: assigned
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Benoît Vinot | Owner: Leo Tom
Component: GIS | Version: 4.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f3822d4ab005ac5db9000ed384519edfd5bbc041" f3822d4a]:
{{{
#!CommitTicketReference repository=""
revision="f3822d4ab005ac5db9000ed384519edfd5bbc041"
Fixed #34026 -- Fixed WKBReader.read() crash on string input.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34026#comment:15>