[Django] #26834: MinValueValidator/MaxValueValidator not forwarded to form field for ModelForm
Django
ModelForm
-------------------------+-------------------------------------------------
Reporter: sergei- | Owner: nobody
maertens |
Type: Bug | Status: new
Component: Forms | Version: 1.9
Severity: Normal | Keywords: MaxValueValidator,
Triage Stage: | MinValueValidator, ModelForm, IntegerField
Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+-------------------------------------------------
I just ran into a possible enhancement.
Consider the following model:
{{{
#!python
DEFAULT_RATING = 50
MAX_RATING = 100
MIN_RATING = 0
class KitReviewPropertyRating(models.Model):
"""
Represents properties for a kit review rated on a scale from
MIN_RATING to MAX_RATING
"""
kit_review = models.ForeignKey('KitReview', related_name='ratings')
prop = models.ForeignKey('KitReviewProperty')
rating = models.PositiveSmallIntegerField(
_('rating'), default=DEFAULT_RATING,
validators=[MinValueValidator(MIN_RATING),
MaxValueValidator(MAX_RATING)]
)
}}}
and the matching ModelForm:
{{{
#!python
from django.forms.widgets import NumberInput
class RangeInput(NumberInput):
input_type = 'range'
class KitReviePropertyRatingForm(forms.ModelForm):
class Meta:
model = KitReviewPropertyRating
fields = ('id', 'prop', 'rating')
widgets = {
'rating': RangeInput(attrs={'max': MAX_RATING})
}
}}}
As you can see, I have to specify the `max` widget attribute manually,
otherwise the html input looks like this: `<input type="range"
name="rating" value="50" min="0">`, instead of the expected `<input
type="range" name="rating" value="50" min="0" max="100">`. I had expected
the Min/MaxValueValidator to be 'forwarded' to the form field (via
`IntegerField.formfield` method), but no such thing happens. #26786 does
add the validators on the model level, based on the db connection used and
the limits there, and only if no such validators were present yet.
I'd like to make it so that Min/MaxValueValidators are translated into
`min_value`/`max_value` defaults for the `IntegerField.formfield` method,
this would be more in line with the expected output and reduce the need to
repeat yourself.
--
Ticket URL: <https://code.djangoproject.com/ticket/26834>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
ModelForm
Reporter: sergei-maertens | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.9
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
Comment:
I'm wary of the additional complexity, but can't say that the request is
unreasonable.
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:1>
Django
ModelForm
Reporter: sergei-maertens | Owner: sgzsh269
Type: Bug | Status: assigned
Component: Forms | Version: 1.9
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sgzsh269):
* owner: nobody => sgzsh269
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:2>
Django
ModelForm
Reporter: sergei-maertens | Owner: sgzsh269
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sgzsh269):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:3>
Django
ModelForm
Reporter: sergei-maertens | Owner: sgzsh269
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sgzsh269):
* version: 1.9 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:4>
Django
ModelForm
Reporter: sergei-maertens | Owner: sgzsh269
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Comments for improvement on the PR (and some failing tests to be fixed).
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:5>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tobias Kunze):
* owner: Sagar Nilesh Shah => Tobias Kunze
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:6>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:7>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by Mariusz Felisiak):
The proposed solution has some side-effects. We should reach a wider
audience and consensus on DevelopersMailingList before moving this
forward.
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:8>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by Claude Paroz):
#25594 might be related.
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:9>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Mariusz Felisiak):
* type: Bug => New feature
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:10>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Type: New feature | Status: assigned
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Ülgen Sarıkavak):
* cc: Ülgen Sarıkavak (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:11>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Tobias
| Kunze
Type: New feature | Status: assigned
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by JaeHyuckSa):
* cc: JaeHyuckSa (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:12>
Django
ModelForm
Reporter: Sergei Maertens | Owner: Clifford
| Gama
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: MaxValueValidator, | Triage Stage: Accepted
MinValueValidator, ModelForm, |
IntegerField |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Clifford Gama):
* owner: Tobias Kunze => Clifford Gama
--
Ticket URL: <https://code.djangoproject.com/ticket/26834#comment:13>