[Django] #28115: geoip2 module broken on master

[Django]

#28115: geoip2 module broken on master
----------------------------------------+------------------------------
Reporter: Claude Paroz | Owner: Claude Paroz
Type: Bug | Status: assigned
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------------
The geoip2 module is currently broken because it can't import
`django.core.validators.ipv4_re`.
The breakage was my commit 277a4dd4b4cc2a2cad77139882f084480751a95a.

The `ImportError` catching in the `__init__` file is currently not
specific enough to catch those failures.

--
Ticket URL: <https://code.djangoproject.com/ticket/28115>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28115: geoip2 module broken on master

------------------------------+----------------------------------------

Reporter: Claude Paroz | Owner: Claude Paroz
Type: Bug | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

------------------------------+----------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/8391 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28115#comment:1>

[Django]

#28115: geoip2 module broken with ImportError on master
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/28115#comment:2>

[Django]

#28115: geoip2 module broken with ImportError on master
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: Claude
| Paroz

Type: Bug | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"3f1ba76851e1dc140d4544fa50a463425be197b2" 3f1ba768]:
{{{
#!CommitTicketReference repository=""
revision="3f1ba76851e1dc140d4544fa50a463425be197b2"
Fixed #28115 -- Fixed IP address validation in geoip2 module

Regression in 277a4dd4b4cc2a2cad77139882f084480751a95a.
Thanks Tim Graham for the test.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28115#comment:4>

[Django]

#28115: geoip2 module broken with ImportError on master
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"257075d4adf9ce0fae8ca1ec3c680dc071fa5a72" 257075d4]:
{{{
#!CommitTicketReference repository=""
revision="257075d4adf9ce0fae8ca1ec3c680dc071fa5a72"
Refs #28115 -- Avoided masking legitimate ImportErrors in geoip2 module
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28115#comment:3>