[Django] #35546: Modernize contributing pages to aling with current requirement of having an accepted ticket for non trivial changes

12 views
Skip to first unread message

Django

unread,
Jun 20, 2024, 2:21:34 PMJun 20
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
------------------------------------------------+------------------------
Reporter: Natalia Bidart | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Following some feedback from https://github.com/django/django/pull/17389,
there are some parts in these docs:

https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-
features/
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/

that could benefit from being more explicit about the need to have an
accepted ticket when working on non trivial changes.

Specifically, I think that this paragraph is misleading:

"As with most open-source projects, code talks. If you are willing to
write the code for the feature yourself or, even better, if you’ve already
written it, it’s much more likely to be accepted. Fork Django on GitHub,
create a feature branch, and show us your work!"

And also the patch review checklist should explicitly mention that an
accepted ticket is required to get reviews/discussion in a GH PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/35546>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 21, 2024, 1:41:32 AMJun 21
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
--------------------------------------+------------------------------------
Reporter: Natalia Bidart | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35546#comment:1>

Django

unread,
Jun 28, 2024, 12:32:19 PM (7 days ago) Jun 28
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
--------------------------------------+------------------------------------
Reporter: Natalia Bidart | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Amir Karimi):

1. I think this paragraph "As with most open-source projects, code
talks..." is kinda contradictory with what is stated above and can be
deleted. I traced its Git history but didn't find out why it was added
while there is a lot of emphasis on submitting tickets first.
2. Obviously, the patch review checklist requires reviews/discussion in
its PR, but we can add it to the patch review checklist section.
--
Ticket URL: <https://code.djangoproject.com/ticket/35546#comment:2>

Django

unread,
Jun 29, 2024, 5:53:40 AM (7 days ago) Jun 29
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
--------------------------------------+------------------------------------
Reporter: Natalia Bidart | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Maryam Yusuf):

I want to work on this. I have gone through the
PR(https://github.com/django/django/pull/17389) to see the feedback. Will
assign it to myself and work on it.
--
Ticket URL: <https://code.djangoproject.com/ticket/35546#comment:3>

Django

unread,
Jun 29, 2024, 5:54:32 AM (7 days ago) Jun 29
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Maryam
Type: | Yusuf
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Maryam Yusuf):

* owner: nobody => Maryam Yusuf
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35546#comment:4>

Django

unread,
4:00 AM (15 hours ago) 4:00 AM
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Maryam
Type: | Yusuf
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Maryam Yusuf):

* cc: Maryam Yusuf (added)
* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35546#comment:5>

Django

unread,
10:00 AM (9 hours ago) 10:00 AM
to django-...@googlegroups.com
#35546: Modernize contributing pages to aling with current requirement of having an
accepted ticket for non trivial changes
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Maryam
Type: | Yusuf
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35546#comment:6>
Reply all
Reply to author
Forward
0 new messages