[Django] #32341: forms.ModelMultipleChoiceField raising TypeError when empty_label provided
Django
-------------------------------------+-------------------------------------
Reporter: thewamz | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 3.1
Severity: Release | Keywords:
blocker | ModelMultipleChoiceField
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
In a django form, when I set a value for the `empty_label` parameter, a
TypeError is raised. TypeError: __init__() got multiple values for keyword
argument 'empty_label'
```
field_name = forms.ModelMultipleChoiceField(
label="Field Label",
queryset=MyModel.objects.all(),
empty_label="Select something",
)
```
--
Ticket URL: <https://code.djangoproject.com/ticket/32341>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: thewamz | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 3.1
Keywords: | Triage Stage:
ModelMultipleChoiceField | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Old description:
> In a django form, when I set a value for the `empty_label` parameter, a
> TypeError is raised. TypeError: __init__() got multiple values for
> keyword argument 'empty_label'
>
> ```
> field_name = forms.ModelMultipleChoiceField(
> label="Field Label",
> queryset=MyModel.objects.all(),
> empty_label="Select something",
> )
> ```
New description:
In a django form, when I set a value for the `empty_label` parameter, a
TypeError is raised. TypeError: __init__() got multiple values for keyword
argument 'empty_label'
`field_name =
forms.ModelMultipleChoiceField(queryset=MyModel.objects.all(),
empty_label="Select something" )`
--
--
Ticket URL: <https://code.djangoproject.com/ticket/32341#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: thewamz | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 3.1
Keywords: | Triage Stage:
ModelMultipleChoiceField | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Old description:
> In a django form, when I set a value for the `empty_label` parameter, a
> TypeError is raised. TypeError: __init__() got multiple values for
> keyword argument 'empty_label'
>
> `field_name =
> forms.ModelMultipleChoiceField(queryset=MyModel.objects.all(),
> empty_label="Select something" )`
New description:
In a django form, when I set a value for the `empty_label` parameter, a
TypeError is raised. TypeError: __init__() got multiple values for keyword
argument 'empty_label'
`field_name =
forms.ModelMultipleChoiceField(queryset=MyModel.objects.all(),
empty_label="Select something")`
--
--
Ticket URL: <https://code.djangoproject.com/ticket/32341#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: thewamz | Owner: nobody
Component: Forms | Version: 3.1
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
ModelMultipleChoiceField | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* ui_ux: 1 => 0
* resolution: => invalid
* severity: Release blocker => Normal
Comment:
`ModelMultipleChoiceField` doesn't support `empty_label` (see
[https://docs.djangoproject.com/en/3.1/ref/forms/fields/#django.forms.ModelMultipleChoiceField
docs]).
--
Ticket URL: <https://code.djangoproject.com/ticket/32341#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: thewamz | Owner: nobody
Component: Forms | Version: 3.1
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
ModelMultipleChoiceField | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/32341#comment:4>
Django
Reporter: thewamz | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 3.1
Keywords: | Triage Stage:
ModelMultipleChoiceField | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by piscvau):
* status: closed => new
* resolution: invalid =>
Comment:
Hello
In version 3.8 of module forms line 1315 , The class
ModelMultipleChoiceField.__init__ calls super().__init__ with empty_label
= None. This a real bug easy to correct.
--
Ticket URL: <https://code.djangoproject.com/ticket/32341#comment:5>
Django
Reporter: thewamz | Owner: nobody
Component: Forms | Version: 3.1
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
ModelMultipleChoiceField | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => invalid
Comment:
Please don't reopen closed ticket. This is not a bug,
`ModelMultipleChoiceField` doesn't support `empty_label` (see
[https://docs.djangoproject.com/en/3.1/ref/forms/fields/#django.forms.ModelMultipleChoiceField
docs]).
--
Ticket URL: <https://code.djangoproject.com/ticket/32341#comment:6>