[Django] #32789: adding support for self closing tags in syndication feeds

16 views
Skip to first unread message

Django

unread,
May 27, 2021, 12:56:42 AM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: The- | Owner: nobody
Daishogun |
Type: New | Status: new
feature |
Component: Utilities | Version: 3.2
Severity: Normal | Keywords: feeds; syndication
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
the code for syndication feeds was written in a time where self closing
tags didn't exist. but today, if an element has no text between the tags,
the standard is that it should be a self closing tag. python added this
functionality in 3.2 to XMLGenerator but django still doesn't use this in
generating syndication feeds. this is the matter of passing a single
argument to the SimplerXMLGenerator that django uses for generating feeds.
since SimplerXMLGenerator directly inherits from pythons XMLGenrator,
passing the arguments works with this class too .
this is my attempt at making it right
[https://github.com/django/django/pull/14451]

--
Ticket URL: <https://code.djangoproject.com/ticket/32789>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 27, 2021, 12:56:57 AM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: The-Daishogun | Owner: The-
| Daishogun
Type: New feature | Status: assigned
Component: Utilities | Version: 3.2
Severity: Normal | Resolution:

Keywords: feeds; syndication | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by The-Daishogun):

* owner: nobody => The-Daishogun
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/32789#comment:1>

Django

unread,
May 27, 2021, 1:01:33 AM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: The-Daishogun | Owner: The-
| Daishogun
Type: New feature | Status: assigned
Component: Utilities | Version: 3.2
Severity: Normal | Resolution:
Keywords: feeds; syndication | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by The-Daishogun):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/32789#comment:2>

Django

unread,
May 27, 2021, 1:16:32 AM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: The-Daishogun | Owner: The-
| Daishogun
Type: New feature | Status: assigned
Component: Utilities | Version: 3.2
Severity: Normal | Resolution:

Keywords: feeds; syndication | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Unreviewed


Comment:

The-Daishogun, you shouldn't accept your own tickets.

--
Ticket URL: <https://code.djangoproject.com/ticket/32789#comment:3>

Django

unread,
May 27, 2021, 1:20:42 AM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: The-Daishogun | Owner: The-
Type: | Daishogun
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 3.2
Severity: Normal | Resolution:
Keywords: feeds; syndication | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 0 => 1
* type: New feature => Cleanup/optimization
* needs_tests: 0 => 1


* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/32789#comment:4>

Django

unread,
May 27, 2021, 3:07:48 PM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: Mohammadreza | Owner:
Varasteh | Mohammadreza Varasteh
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.syndication | Version: 3.2
Severity: Normal | Resolution:
Keywords: feeds; syndication | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 1 => 0
* component: Utilities => contrib.syndication
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32789#comment:5>

Django

unread,
May 27, 2021, 4:03:01 PM5/27/21
to django-...@googlegroups.com
#32789: adding support for self closing tags in syndication feeds
-------------------------------------+-------------------------------------
Reporter: Mohammadreza | Owner:
Varasteh | Mohammadreza Varasteh
Type: | Status: closed

Cleanup/optimization |
Component: contrib.syndication | Version: 3.2
Severity: Normal | Resolution: fixed

Keywords: feeds; syndication | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e93eb3d9714be0b489891f4d2da41bb4df4978a5" e93eb3d9]:
{{{
#!CommitTicketReference repository=""
revision="e93eb3d9714be0b489891f4d2da41bb4df4978a5"
Fixed #32789 -- Made feeds emit elements with no content as self-closing
tags.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32789#comment:6>

Reply all
Reply to author
Forward
0 new messages