[Django] #31789: Add a cleaner interface for response headers
Django
------------------------------------------------+------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
This proposal is to replace `HttpResponse._headers` with
`HttpResponse.headers` as a public interface using a variation of
`django.utils.datasctructures.CaseInsensitiveMapping`.
It also includes updating tests and documentation to use this, rather than
the old dict-like interface, i.e. `response.headers['Content-Type'] =
'application/json'` `response['Content-Type'] = 'application/json'`.
The dict-like interface won't be deprecated, but will become undocumented,
and tests added purely for backwards-compatibility.
[https://groups.google.com/u/2/g/django-developers/c/rlt1HhEaPaM Mailing
list]
[https://github.com/django/django/pull/13186 Draft PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31789>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: 3.0
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tom Carrick):
* owner: nobody => Tom Carrick
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:1>
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tom Carrick):
* needs_docs: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:2>
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tom Carrick):
* needs_docs: 1 => 0
* version: 3.0 => master
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:3>
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Asif Saifuddin Auvi):
* stage: Unreviewed => Accepted
Comment:
I believe this should be accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:4>
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Tom Carrick:
Old description:
> This proposal is to replace `HttpResponse._headers` with
> `HttpResponse.headers` as a public interface using a variation of
> `django.utils.datasctructures.CaseInsensitiveMapping`.
>
> It also includes updating tests and documentation to use this, rather
> than the old dict-like interface, i.e. `response.headers['Content-Type']
> = 'application/json'` `response['Content-Type'] = 'application/json'`.
>
> The dict-like interface won't be deprecated, but will become
> undocumented, and tests added purely for backwards-compatibility.
>
> [https://groups.google.com/u/2/g/django-developers/c/rlt1HhEaPaM Mailing
> list]
> [https://github.com/django/django/pull/13186 Draft PR]
New description:
This proposal is to replace `HttpResponse._headers` with
`HttpResponse.headers` as a public interface using a variation of
`django.utils.datasctructures.CaseInsensitiveMapping`.
It also includes updating tests and documentation to use this, rather than
the old dict-like interface, i.e. `response.headers['Content-Type'] =
'application/json'` `response['Content-Type'] = 'application/json'`.
The dict-like interface won't be deprecated, but will become undocumented,
and tests added purely for backwards-compatibility.
[https://groups.google.com/u/2/g/django-developers/c/rlt1HhEaPaM Mailing
list]
[https://github.com/django/django/pull/13186 PR]
--
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:5>
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:6>
Django
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Component: HTTP handling | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"bcc2befd0e9c1885e45b46d0b0bcdc11def8b249" bcc2befd]:
{{{
#!CommitTicketReference repository=""
revision="bcc2befd0e9c1885e45b46d0b0bcdc11def8b249"
Fixed #31789 -- Added a new headers interface to HttpResponse.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31789#comment:7>