Re: [Django] #32069: Admin change form layout broken at narrower browser widths in 3.1.2

25 views
Skip to first unread message

Django

unread,
Oct 4, 2020, 4:45:38 AM10/4/20
to django-...@googlegroups.com
#32069: Admin change form layout broken at narrower browser widths in 3.1.2
---------------------------------+------------------------------------
Reporter: Phil Gyford | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Carlton Gibson):

* cc: Tom Carrick (added)
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Yep, thanks for the report. Looks like 100% width at the smallest size is
affected.

Regression in 8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822

--
Ticket URL: <https://code.djangoproject.com/ticket/32069#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 5, 2020, 3:13:35 PM10/5/20
to django-...@googlegroups.com
#32069: Admin change form layout broken at narrower browser widths in 3.1.2
-------------------------------------+-------------------------------------
Reporter: Phil Gyford | Owner: Benjamin
| Richter
Type: Bug | Status: assigned

Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Benjamin Richter):

* owner: nobody => Benjamin Richter
* status: new => assigned


Comment:

I will work on this.

--
Ticket URL: <https://code.djangoproject.com/ticket/32069#comment:2>

Django

unread,
Oct 21, 2020, 8:28:45 AM10/21/20
to django-...@googlegroups.com
#32069: Admin change form layout broken at narrower browser widths in 3.1.2
-------------------------------------+-------------------------------------
Reporter: Phil Gyford | Owner: Benjamin
| Richter
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32069#comment:5>

Django

unread,
Oct 21, 2020, 9:07:04 AM10/21/20
to django-...@googlegroups.com
#32069: Admin change form layout broken at narrower browser widths in 3.1.2
-------------------------------------+-------------------------------------
Reporter: Phil Gyford | Owner: Benjamin
| Richter
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"257f8495d6c93e30ab0f52af4c488d7344bcf112" 257f8495]:
{{{
#!CommitTicketReference repository=""
revision="257f8495d6c93e30ab0f52af4c488d7344bcf112"
Fixed #32069 -- Fixed admin change-form layout on small screens.

Restored flex-wrap CSS declaration to form elements at smallest
breakpoint.
This was present since the responsive admin was introduced in
dc37e8846eeedc3a9100ca21fdc9d579bc534c89.
Regression in 8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822, where it was
accidentally removed.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32069#comment:6>

Django

unread,
Oct 21, 2020, 9:10:15 AM10/21/20
to django-...@googlegroups.com
#32069: Admin change form layout broken at narrower browser widths in 3.1.2
-------------------------------------+-------------------------------------
Reporter: Phil Gyford | Owner: Benjamin
| Richter
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson <carlton.gibson@…>):

In [changeset:"b37d5849b76348cdcc623cdc677611f8dbf2e1db" b37d5849]:
{{{
#!CommitTicketReference repository=""
revision="b37d5849b76348cdcc623cdc677611f8dbf2e1db"
[3.1.x] Fixed #32069 -- Fixed admin change-form layout on small screens.

Restored flex-wrap CSS declaration to form elements at smallest
breakpoint.
This was present since the responsive admin was introduced in
dc37e8846eeedc3a9100ca21fdc9d579bc534c89.
Regression in 8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822, where it was
accidentally removed.

Backport of 257f8495d6c93e30ab0f52af4c488d7344bcf112 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32069#comment:7>

Reply all
Reply to author
Forward
0 new messages