[Django] #23884: Consider moving FlatPageSitemap to contrib.flatpages
Django
--------------------------------------+--------------------
Reporter: kezabelle | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.sitemaps | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
The FlatPageSitemap currently exists within the 'core'
`django.contrib.sitemaps` namespace, though it's specific to
`django.contrib.flatpages`. Given a number of modules and moves have
happened recently, I'm floating the idea of:
* Moving `FlatPageSitemap` to `django.contrib.flatpages.sitemaps`, which
would better reflect it's dependencies (though it still has one to
`django.contrib.sites`), and is more inline with how sitemaps would be
packaged in third-party apps (and would allow spinning out flatpages to an
external app with less work, if ever desired)
* Raising a deprecation warning for a release, if importing from the old
namespace (like the ContentTypes move and form.util moves)
The documentation currently says ''The sitemap framework provides a couple
convenience classes for common cases'', and I'd argue that flatpages isn't
all *that* common, these days, though it may have been in the past (before
richer packages either built on it or supplanted it, because the ecosystem
was smaller)
--
Ticket URL: <https://code.djangoproject.com/ticket/23884>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: kezabelle | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.sitemaps | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:1>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by berkerpeksag):
* owner: nobody => berkerpeksag
* status: new => assigned
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/3710
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:2>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Test failure needs fixing.
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:3>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by berkerpeksag):
* needs_better_patch: 1 => 0
Comment:
I've fixed the test failures: http://djangoci.com/job/django-pull-
requests/2003/
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:4>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9aeb917dad2c3d4c2830f38d3bfc63699e0ba837"]:
{{{
#!CommitTicketReference repository=""
revision="9aeb917dad2c3d4c2830f38d3bfc63699e0ba837"
Fixed #23884 -- Moved FlatPageSitemap into django.contrib.flatpages.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:5>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Component: contrib.sitemaps | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: closed => new
* has_patch: 1 => 0
* resolution: fixed =>
Comment:
Please look at silencing the deprecation warning when running the tests in
reverse: http://djangoci.com/job/django-master-trusty-reverse/
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:6>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Component: contrib.sitemaps | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"4efe1b79e9462318ff8b2c76a09c5925ad0e0f7c"]:
{{{
#!CommitTicketReference repository=""
revision="4efe1b79e9462318ff8b2c76a09c5925ad0e0f7c"
Refs #23884 -- Silenced a deprecation warning in sitemaps tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:7>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:8>
Django
Reporter: kezabelle | Owner:
Type: | berkerpeksag
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"c2d5f2903cfaef4f8b17d86f4db706b61073a471"]:
{{{
#!CommitTicketReference repository=""
revision="c2d5f2903cfaef4f8b17d86f4db706b61073a471"
Removed contrib.flatpages.FlatPageSitemap per deprecation timeline; refs
#23884.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23884#comment:9>