[Django] #33250: EmailField's label in PasswordResetForm does not match the verbose_name of AbstractUser's EmailField

4 views

Skip to first unread message

Django

unread,

Oct 31, 2021, 9:07:04 AM10/31/21

to django-...@googlegroups.com

#33250: EmailField's label in PasswordResetForm does not match the verbose_name of
AbstractUser's EmailField
-------------------------------------------+----------------------------
Reporter: Zoltán Szatmáry | Owner: nobody
Type: Bug | Status: assigned
Component: contrib.auth | Version: 3.2
Severity: Normal | Keywords: EmailField
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+----------------------------
django/contrib/auth/models.py:342

email = models.EmailField(_('email address'), blank=True)

django/contrib/auth/forms.py:242-246

email = forms.EmailField(
label=_("Email"),
max_length=254,
widget=forms.EmailInput(attrs={'autocomplete': 'email'})
)

--
Ticket URL: <https://code.djangoproject.com/ticket/33250>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Nov 1, 2021, 12:28:51 AM11/1/21

to django-...@googlegroups.com

#33250: EmailField's label in PasswordResetForm doesn't match the verbose_name of
AbstractUser's EmailField
-------------------------------------+-------------------------------------

Reporter: Zoltán Szatmáry | Owner: nobody

Type: | Status: closed
Cleanup/optimization |
Component: contrib.auth | Version: 3.2
Severity: Normal | Resolution: wontfix

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: assigned => closed
* type: Bug => Cleanup/optimization
* resolution: => wontfix

Old description:

> django/contrib/auth/models.py:342
>
> email = models.EmailField(_('email address'), blank=True)
>
> django/contrib/auth/forms.py:242-246
>
> email = forms.EmailField(
> label=_("Email"),
> max_length=254,
> widget=forms.EmailInput(attrs={'autocomplete': 'email'})
> )

New description:

{{{
django/contrib/auth/models.py:342

email = models.EmailField(_('email address'), blank=True)

django/contrib/auth/forms.py:242-246

email = forms.EmailField(
label=_("Email"),
max_length=254,
widget=forms.EmailInput(attrs={'autocomplete': 'email'})
)
}}}

Comment:

Thanks for this report, however IMO there is no need for them to be
identical. The `Email` is completely valid and acceptable in the
`PasswordResetForm`, it's not worth changing and creating extra work for
translators.