Re: [Django] #31755: make temporal subtraction work without ExpressionWrapper

8 views
Skip to first unread message

Django

unread,
Jun 30, 2020, 2:02:06 PM6/30/20
to django-...@googlegroups.com
#31755: make temporal subtraction work without ExpressionWrapper
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Uncategorized | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev):

* owner: nobody => Sergey Fedoseev
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/31755#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 30, 2020, 2:12:44 PM6/30/20
to django-...@googlegroups.com
#31755: make temporal subtraction work without ExpressionWrapper
-------------------------------------+-------------------------------------
Reporter: Sergey | Owner: nobody
Fedoseev |
Type: | Status: new
Uncategorized |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |

Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
{{{
class Experiment(models.Model):
start = models.DateTimeField()
end = models.DateTimeField()

Experiment.objects.annotate(
delta=F('end') - F('start') + Value(datetime.timedelta(),
output_field=DurationField())
)
}}}
This gives:
{{{
django.core.exceptions.FieldError: Expression contains mixed types:
DateTimeField, DurationField. You must set output_field.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31755>

Django

unread,
Jul 1, 2020, 3:16:15 AM7/1/20
to django-...@googlegroups.com
#31755: make temporal subtraction work without ExpressionWrapper
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Uncategorized | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


Comment:

Hi Sergey. Thanks — yes, it would be nice it that worked.

--
Ticket URL: <https://code.djangoproject.com/ticket/31755#comment:3>

Django

unread,
Jul 1, 2020, 5:39:48 AM7/1/20
to django-...@googlegroups.com
#31755: make temporal subtraction work without ExpressionWrapper
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* type: Uncategorized => Cleanup/optimization


--
Ticket URL: <https://code.djangoproject.com/ticket/31755#comment:4>

Django

unread,
Jul 1, 2020, 5:03:49 PM7/1/20
to django-...@googlegroups.com
#31755: make temporal subtraction work without ExpressionWrapper
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31755#comment:5>

Django

unread,
Jul 1, 2020, 5:40:12 PM7/1/20
to django-...@googlegroups.com
#31755: make temporal subtraction work without ExpressionWrapper
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"9d519d3dc4e5bd1d9ff3806b44624c3e487d61c1" 9d519d3]:
{{{
#!CommitTicketReference repository=""
revision="9d519d3dc4e5bd1d9ff3806b44624c3e487d61c1"
Fixed #31755 -- Made temporal subtraction resolve output field.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31755#comment:6>

Reply all
Reply to author
Forward
0 new messages