[Django] #25629: Some GIS functions don't check the number of arguments
Django
------------------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
GIS functions using their parent (GeoFunc) default `__init__` don't check
that the number of passed arguments is correct (e.g. Area). This should be
improved, because currently, the result is a ProgrammingError when hitting
the backend instead of a TypeError.
--
Ticket URL: <https://code.djangoproject.com/ticket/25629>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: claudep | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* owner: nobody => sir-sigurd
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/25629#comment:1>
Django
Reporter: claudep | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by sir-sigurd):
PR -- https://github.com/django/django/pull/5499
--
Ticket URL: <https://code.djangoproject.com/ticket/25629#comment:2>
Django
Reporter: claudep | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25629#comment:3>
Django
Reporter: claudep | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"0a26121797b5e0aa07ada07fe1577a79d3853c40" 0a26121]:
{{{
#!CommitTicketReference repository=""
revision="0a26121797b5e0aa07ada07fe1577a79d3853c40"
Refs #25629 -- Added `arity` class attribute to `Func` expressions
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25629#comment:4>
Django
Reporter: claudep | Owner: sir-
Type: | sigurd
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a449b7ef99efdbb5edc8b4aacc89eb6020145dd3" a449b7ef]:
{{{
#!CommitTicketReference repository=""
revision="a449b7ef99efdbb5edc8b4aacc89eb6020145dd3"
Fixed #25629 -- Added checks of the number of arguments for GeoDjango DB
functions.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25629#comment:5>