[Django] #33235: MultiWidget id_for_label
Django
------------------------------------------------+------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The instance from Raw MultiWidget class generate id_for_label like
f'{id_}0'
It has not sense.
For example ChoiceWidget has self.add_id_index and I can decide it myself,
how I will see label_id - with or without index.
I think, it is better to remove completely id_for_label method from
MultiWidget Class.
--
Ticket URL: <https://code.djangoproject.com/ticket/33235>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Cleanup/optimization |
Component: Forms | Version: 3.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
forms, wcag |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: Thibaud Colas, David Smith, Tom Carrick (added)
* keywords: => accessibility, forms, wcag
* stage: Unreviewed => Accepted
Comment:
I agree that we should remove `for` from MultiWidget's `<label>` but not
because ''"It has not sense"'' but to improve accessibility when using a
screen reader, see also #32338. It should be enough to return an empty
string:
{{{#!python
def id_for_label(self, id_):
return ''
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33235#comment:1>
Django
-------------------------------------+-------------------------------------
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: 3.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
forms, wcag |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by David Smith):
* owner: nobody => David Smith
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33235#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
forms, wcag |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/15061 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33235#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Ready for
forms, wcag | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33235#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: David
Type: | Smith
Component: Forms | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
forms, wcag | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"c6c6cd3c5ad9c36795bb120e521590424f034ae4" c6c6cd3]:
{{{
#!CommitTicketReference repository=""
revision="c6c6cd3c5ad9c36795bb120e521590424f034ae4"
Fixed #33235 -- Removed "for = ..." from MultiWidget's <label>.
This improves accessibility for screen reader users.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33235#comment:5>