[Django] #32091: Admin search input on small widths is too small with selected list filter

16 views
Skip to first unread message

Django

unread,
Oct 8, 2020, 3:41:43 PM10/8/20
to django-...@googlegroups.com
#32091: Admin search input on small widths is too small with selected list filter
---------------------------------------------+------------------------
Reporter: Timothy Schilling | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
The search input shrinks down to an unusable level when the window's width
is too small. This only occurs when there's a selected list filter causing
the `10 results (100 total)` span to appear. This should be reproducible
from the admin where there's a search field and a list filter selected.
Simply make the window skinny.

I've only tested this on FF on Ubuntu, but my colleague reported it with
Chrome.

I've confirmed a fix in `contrib/admin/css/responsive.css` by changing the
following style:


{{{
#changelist-search .quiet {
width: 100%;
margin: 5px 0 0 25px;
}
}}}


to


{{{
#changelist-search .quiet {
flex: 1 0 auto;
width: 0;
margin: 5px 0 0 25px;
}
}}}


This matches the #searchbar style above it.

You can see the problem in my screenshots. The immediate resolution for
users is to make the window slightly larger.

I will be creating a PR for this shortly.

--
Ticket URL: <https://code.djangoproject.com/ticket/32091>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 8, 2020, 3:42:21 PM10/8/20
to django-...@googlegroups.com
#32091: Admin search input on small widths is too small with selected list filter
-----------------------------------+--------------------------------------

Reporter: Timothy Schilling | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Timothy Schilling):

* Attachment "search_skinny_window.png" added.

View showing the search input as too small with a skinny window.

Django

unread,
Oct 8, 2020, 3:42:45 PM10/8/20
to django-...@googlegroups.com
#32091: Admin search input on small widths is too small with selected list filter
-----------------------------------+--------------------------------------

Reporter: Timothy Schilling | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Timothy Schilling):

* Attachment "search_wide_window.png" added.

View showing the search input with a slightly wider window.

Django

unread,
Oct 8, 2020, 3:45:46 PM10/8/20
to django-...@googlegroups.com
#32091: Admin search input on small widths is too small with selected list filter
-----------------------------------+--------------------------------------

Reporter: Timothy Schilling | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 3.1
Severity: Normal | Resolution:
Keywords: css admin | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Timothy Schilling):

* keywords: => css admin
* has_patch: 0 => 1
* component: Uncategorized => contrib.admin


Comment:

PR on github: https://github.com/django/django/pull/13517

--
Ticket URL: <https://code.djangoproject.com/ticket/32091#comment:1>

Django

unread,
Oct 9, 2020, 5:07:25 AM10/9/20
to django-...@googlegroups.com
#32091: Admin search input on small widths is too small with selected list filter
-------------------------------------+-------------------------------------
Reporter: Timothy Schilling | Owner: tim-
| schilling
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: css admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32091#comment:3>

Django

unread,
Oct 9, 2020, 6:10:28 AM10/9/20
to django-...@googlegroups.com
#32091: Admin search input on small widths is too small with selected list filter
-------------------------------------+-------------------------------------
Reporter: Timothy Schilling | Owner: tim-
| schilling
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed

Keywords: css admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"b7da588e883e12b8ac3bb8a486e654e30fc1c6c8" b7da588]:
{{{
#!CommitTicketReference repository=""
revision="b7da588e883e12b8ac3bb8a486e654e30fc1c6c8"
Fixed #32091 -- Fixed admin search bar width on filtered admin page.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32091#comment:4>

Reply all
Reply to author
Forward
0 new messages