[Django] #32603: Changelist view in admin is missing transaction
Django
------------------------------------------+------------------------
Reporter: Vlastimil Zíma | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
It seems that `changelist_view` in Django admin is missing a transaction.
Since the view may change data in database, it should be wrapped in a
transaction to prevent unexpected states in case of errors.
--
Ticket URL: <https://code.djangoproject.com/ticket/32603>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------+------------------------------------
Reporter: Vlastimil Zíma | Owner: nobody
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* type: Bug => New feature
* stage: Unreviewed => Accepted
Comment:
So, this has never been wrapped in a transaction.
See https://github.com/django/django/commit/7bc0878922 where it was added.
Happy to accept as a New Feature to investigate adding that. (I can't
immediately see any obvious blockers.)
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:1>
Django
Reporter: Vlastimil Zíma | Owner: Danil
| Khismatulin
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Danil Khismatulin):
* owner: nobody => Danil Khismatulin
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:2>
Django
Reporter: Vlastimil Zíma | Owner: Shubh Parmar
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Shubh Parmar):
* owner: nobody => Shubh Parmar
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:2>
Django
--------------------------------+----------------------------------------
Reporter: Vlastimil Zíma | Owner: Shubh Parmar
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/16100 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:3>
Django
--------------------------------+----------------------------------------
Reporter: Vlastimil Zíma | Owner: Shubh Parmar
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:4>
Django
--------------------------------+----------------------------------------
Reporter: Vlastimil Zíma | Owner: Shubh Parmar
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Shubh Parmar):
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:5>
Django
--------------------------------+----------------------------------------
Reporter: Vlastimil Zíma | Owner: Shubh Parmar
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:6>
Django
Reporter: Vlastimil Zíma | Owner: Shubh
| Parmar
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Vlastimil Zíma | Owner: Shubh
| Parmar
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7a39a691e1e3fe13588c8885a222eaa6a4648d01" 7a39a691]:
{{{
#!CommitTicketReference repository=""
revision="7a39a691e1e3fe13588c8885a222eaa6a4648d01"
Fixed #32603 -- Made ModelAdmin.list_editable use transactions.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32603#comment:8>