[Django] #30314: Enable SESSION_COOKIE_SECURE by Default

12 views
Skip to first unread message

Django

unread,
Apr 2, 2019, 1:25:06 PM4/2/19
to django-...@googlegroups.com
#30314: Enable SESSION_COOKIE_SECURE by Default
-----------------------------------------+------------------------
Reporter: nstr10 | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------+------------------------
Per the documentation, "Leaving this setting off isn’t a good idea because
an attacker could capture an unencrypted session cookie with a packet
sniffer and use the cookie to hijack the user’s session."

If it's not a good idea for this setting to be off, why is it off by
default? Seems backwards to me.

--
Ticket URL: <https://code.djangoproject.com/ticket/30314>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 3, 2019, 4:03:30 AM4/3/19
to django-...@googlegroups.com
#30314: Enable SESSION_COOKIE_SECURE by Default
--------------------------------------+------------------------------------
Reporter: nstr10 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.sessions | Version: 2.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

* type: Uncategorized => Cleanup/optimization
* version: 2.1 => 2.2
* component: Uncategorized => contrib.sessions
* stage: Unreviewed => Accepted


Comment:

OK, seems reasonable, yes.

Will need a note as a breaking changing in the 3.0 release notes.

I've [https://groups.google.com/d/topic/django-
developers/sym7XXrM9w8/discussion asked on the mailing list] if there are
any reasons not to do this.

--
Ticket URL: <https://code.djangoproject.com/ticket/30314#comment:1>

Django

unread,
Apr 3, 2019, 5:44:37 AM4/3/19
to django-...@googlegroups.com
#30314: Enable SESSION_COOKIE_SECURE by Default
-------------------------------------+-------------------------------------
Reporter: nstr10 | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.sessions | Version: 2.2
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* status: new => closed
* resolution: => wontfix
* easy: 1 => 0
* stage: Accepted => Unreviewed


Comment:

As per input on the mailing list, adjusting the default here would cause
issues logging in when using the development server.

The system check framework will raise a warning here when running with the
`--deploy` flag.

--
Ticket URL: <https://code.djangoproject.com/ticket/30314#comment:2>

Reply all
Reply to author
Forward
0 new messages