[Django] #21298: pep8 cleanup: expected 1 blank line, found 0

3 views
Skip to first unread message

Django

unread,
Oct 21, 2013, 10:38:19 AM10/21/13
to django-...@googlegroups.com
#21298: pep8 cleanup: expected 1 blank line, found 0
------------------------------------------------+------------------------
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
To find errors, ensure you have an up-to-date master with the flake8
config in setup.cfg, then remove E301 from the ignore list there. You can
then run `flake8` from the directory with setup.cfg in it to list all
errors - there should be about 200.

Note I also added `./django/utils/six.py` to the ignore list since it had
some of these errors but we don't care about fixing it since it's mostly a
copy of a 3rd party library.

Attaching an example patch to get you started.

Apply it, if you'd like:

`patch -p1 -i E301.diff`

--
Ticket URL: <https://code.djangoproject.com/ticket/21298>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 23, 2013, 8:54:39 AM10/23/13
to django-...@googlegroups.com
#21298: pep8 cleanup: expected 1 blank line, found 0
--------------------------------------+------------------------------------

Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by alasdair):

Pull request https://github.com/django/django/pull/1798

--
Ticket URL: <https://code.djangoproject.com/ticket/21298#comment:1>

Django

unread,
Oct 23, 2013, 9:06:10 AM10/23/13
to django-...@googlegroups.com
#21298: pep8 cleanup: expected 1 blank line, found 0
--------------------------------------+------------------------------------
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Alasdair Nicol <alasdair@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"c3aa2948c6c14862407501290571f858ccf45b07"]:
{{{
#!CommitTicketReference repository=""
revision="c3aa2948c6c14862407501290571f858ccf45b07"
Fixed #21298 -- Fixed E301 pep8 warnings
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21298#comment:2>

Reply all
Reply to author
Forward
0 new messages