[Django] #27489: Renaming a model doesn't rename the permission name and codename

[Django]

#27489: Renaming a model doesn't rename the permission name and codename
----------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------
After a `RenameModel` operation, new permissions are created with the name
and codename of the new model name rather than renaming the permissions
with the old model name. It should be feasible to fix by using an approach
similar to f179113e6cbc8ba0a8d4e87e1d4410fb61d63e75 where a
`RenamePermission` operation is injected in the plan after each
`RenameModel` operation.

#26756 requires the same approach except that the `RenamePermission`
operation must be inserted after `AlterModelOptions` operations with a
`verbose_name` key.

--
Ticket URL: <https://code.djangoproject.com/ticket/27489>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+-----------------------------------------
Reporter: Tim Graham | Owner: Morgan Aubert
Type: Bug | Status: assigned
Component: contrib.auth | Version: 1.10
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

------------------------------+-----------------------------------------
Changes (by Morgan Aubert):

* status: new => assigned
* owner: nobody => Morgan Aubert

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:1>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+-----------------------------------------
Reporter: Tim Graham | Owner: Morgan Aubert
Type: Bug | Status: assigned

Component: contrib.auth | Version: 1.10
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

------------------------------+-----------------------------------------

Comment (by Morgan Aubert):

Added [https://github.com/django/django/pull/7673 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:2>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+-----------------------------------------
Reporter: Tim Graham | Owner: Morgan Aubert
Type: Bug | Status: assigned

Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

------------------------------+-----------------------------------------
Changes (by Simon Charette):

* has_patch: 0 => 1
* version: 1.10 => master

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:3>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+-----------------------------------------
Reporter: Tim Graham | Owner: Morgan Aubert
Type: Bug | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

------------------------------+-----------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1

Comment:

I left comments for improvement on the patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:4>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Type: Bug | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* owner: Morgan Aubert => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:5>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)

Type: Bug | Status: new
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

------------------------------+------------------------------------

Comment (by Natalia Bidart):

Duplicates of this are #32715 and #34762.

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:6>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+---------------------------------------
Reporter: Tim Graham | Owner: mrartem1927
Type: Bug | Status: assigned

Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

------------------------------+---------------------------------------
Changes (by mrartem1927):

* owner: (none) => mrartem1927

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:7>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+---------------------------------------
Reporter: Tim Graham | Owner: mrartem1927
Type: Bug | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

------------------------------+---------------------------------------
Comment (by mrartem1927):

PR for this [https://github.com/django/django/pull/19405]
--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:8>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+---------------------------------------
Reporter: Tim Graham | Owner: mrartem1927
Type: Bug | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

------------------------------+---------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 1 => 0

Comment:

Don't forget to update the ticket's flags so the ticket appears in the
review queue.
--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:9>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+---------------------------------------
Reporter: Tim Graham | Owner: mrartem1927
Type: Bug | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:10>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+---------------------------------------
Reporter: Tim Graham | Owner: mrartem1927
Type: Bug | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

------------------------------+---------------------------------------
Changes (by mrartem1927):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:11>

[Django]

#27489: Renaming a model doesn't rename the permission name and codename

------------------------------+---------------------------------------
Reporter: Tim Graham | Owner: mrartem1927
Type: Bug | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/27489#comment:12>