[Django] #29959: Random LooseVersion errors while getting multiple wkb values
Django
-------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 2.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
From [f185d929fa1c0caa], each call to geometry `wkb` value (used in the
json representation) will call `GEOSversion()` to test a corner case
condition.
Unfortunately and randomly, this causes `'LooseVersion' object has no
attribute 'version'` errors. It might be memory related because the same
operation sometimes fails, sometimes succeeds in the exact same code
conditions.
It's hard to know what part of the code to blame, but I would argue that
calling a GEOS method for each wkb value retrieval is suboptimal, as the
GEOS version should not change between server restart. We may find a way
to cache the GEOS version between calls.
--
Ticket URL: <https://code.djangoproject.com/ticket/29959>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 2.1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/29959#comment:1>
Django
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 2.1
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/commit/f185d929fa1c0caad8c03fccde899b647d7248c6
Suggested fix]
--
Ticket URL: <https://code.djangoproject.com/ticket/29959#comment:2>
Django
Reporter: Claude Paroz | Owner: nobody
Component: GIS | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"e7e55059027ae2f644c852e0ba60dc9307b425e1" e7e55059]:
{{{
#!CommitTicketReference repository=""
revision="e7e55059027ae2f644c852e0ba60dc9307b425e1"
Fixed #29959 -- Cached GEOS version in WKBWriter class.
Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29959#comment:3>
Django
Reporter: Claude Paroz | Owner: nobody
Component: GIS | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"0991940c88fde64da3d59c786bb52ee2b9250c4b" 0991940c]:
{{{
#!CommitTicketReference repository=""
revision="0991940c88fde64da3d59c786bb52ee2b9250c4b"
[2.1.x] Fixed #29959 -- Cached GEOS version in WKBWriter class.
Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.
Backport of e7e55059027ae2f644c852e0ba60dc9307b425e1 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29959#comment:4>
Django
Reporter: Claude Paroz | Owner: nobody
Component: GIS | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"3cc125b582e5348ae97cc6d555288fa6bf025781" 3cc125b]:
{{{
#!CommitTicketReference repository=""
revision="3cc125b582e5348ae97cc6d555288fa6bf025781"
[2.0.x] Fixed #29959 -- Cached GEOS version in WKBWriter class.
Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.
Backport of e7e55059027ae2f644c852e0ba60dc9307b425e1 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29959#comment:5>
Django
Reporter: Claude Paroz | Owner: nobody
Component: GIS | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"216398d1b12bc63a82580705ad9f9ed00b28ac4a" 216398d]:
{{{
#!CommitTicketReference repository=""
revision="216398d1b12bc63a82580705ad9f9ed00b28ac4a"
[1.11.x] Fixed #29959 -- Cached GEOS version in WKBWriter class.
Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.
Backport of e7e55059027ae2f644c852e0ba60dc9307b425e1 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29959#comment:6>