[Django] #24285: get_admin_log template tag doesn't work without for_user parameter
Django
-------------------------------+--------------------
Reporter: yairchu | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
The get_admin_log template tag from django.contrib.admin.templatetags.log
does not work when not using it's "for_user" option (which is being used
in the default admin site index.html template)
--
Ticket URL: <https://code.djangoproject.com/ticket/24285>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: yairchu | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by yairchu):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
patch in https://github.com/django/django/pull/4060
--
Ticket URL: <https://code.djangoproject.com/ticket/24285#comment:1>
Django
Reporter: yairchu | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: 0 => 1
* type: Bug => Cleanup/optimization
* easy: 1 => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24285#comment:2>
Django
Reporter: yairchu | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by yairchu):
I'd call it a bug, although minor. The tag causes a TypeError when used as
described in its documentation (which provides the "{% get_admin_log 10 as
admin_log %}" example), although minor because that use case isn't used in
the default admin site templates.
--
Ticket URL: <https://code.djangoproject.com/ticket/24285#comment:3>
Django
Reporter: yairchu | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by yairchu):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24285#comment:4>
Django
Reporter: yairchu | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"eb5ebcc2d0b13737127e3478bced98a84962a5d0" eb5ebcc2]:
{{{
#!CommitTicketReference repository=""
revision="eb5ebcc2d0b13737127e3478bced98a84962a5d0"
Fixed #24285 -- Made for_user argument optional for {% get_admin_log %}
tag
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24285#comment:5>