Re: [Django] #36103: Simplify get_namespace() and adjust get_and_report_namespace() method signature for automatic imports in Shell command

[Django]

#36103: Simplify get_namespace() and adjust get_and_report_namespace() method
signature for automatic imports in Shell command
-------------------------------------+-------------------------------------
Reporter: Salvo Polizzi | Owner: Salvo
Type: | Polizzi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: 5.2
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Salvo Polizzi):

Replying to [comment:2 Natalia Bidart]:
> Thank you Salvo for this ticket, I overall agree except for the
`no_imports`, I have no problem to remove it from
`get_and_report_namespace` but we should do it in a way that does not
duplicate logic/checks. Thank you!

Maybe we can wait until someone has other better ideas for the
`no_imports` and in the meantime stick with this implementation, e.g.
leave it as a parameter.
--
Ticket URL: <https://code.djangoproject.com/ticket/36103#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36103: Simplify get_namespace() and adjust get_and_report_namespace() method
signature for automatic imports in Shell command
-------------------------------------+-------------------------------------
Reporter: Salvo Polizzi | Owner: Salvo
Type: | Polizzi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: 5.2
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Salvo Polizzi):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36103#comment:5>

[Django]

#36103: Simplify get_namespace() and adjust get_and_report_namespace() method
signature for automatic imports in Shell command
-------------------------------------+-------------------------------------
Reporter: Salvo Polizzi | Owner: Salvo
Type: | Polizzi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: 5.2
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

Comment:

Hi Salvo, if you could resolve the merge conflicts that would help us
assess next steps. Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/36103#comment:6>

[Django]

#36103: Simplify get_namespace() and adjust get_and_report_namespace() method
signature for automatic imports in Shell command
-------------------------------------+-------------------------------------
Reporter: Salvo Polizzi | Owner: Salvo
Type: | Polizzi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: 5.2
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Salvo Polizzi):

Replying to [comment:6 Jacob Walls]:

> Hi Salvo, if you could resolve the merge conflicts that would help us
assess next steps. Thanks.

Hi, after reviewing Natalia's patch
(https://github.com/django/django/pull/19147), I believe this ticket might
no longer be necessary. Could you please let me know if I should close the
PR or if further action is needed? Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/36103#comment:7>

[Django]

#36103: Simplify get_namespace() and adjust get_and_report_namespace() method
signature for automatic imports in Shell command
-------------------------------------+-------------------------------------
Reporter: Salvo Polizzi | Owner: Salvo
Type: | Polizzi

Cleanup/optimization | Status: closed

Component: Core (Management | Version: 5.2
commands) |

Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* resolution: => duplicate
* status: assigned => closed

Comment:

I think the PR can be closed. Appreciate the confirmation.

Not sure of the best resolution to approximate "overcome by events" but
I'll choose duplicate for now? This cleanup was mooted by #36158.
--
Ticket URL: <https://code.djangoproject.com/ticket/36103#comment:8>