[Django] #22648: Overridden get_lookup/get_transform not chainable
Django
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: master
layer (models, ORM) | Keywords:
Severity: Normal | Has patch: 0
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
If a transform has an `output_type` which has a customised `get_transform`
or `get_lookup` function, then it is not properly called.
--
Ticket URL: <https://code.djangoproject.com/ticket/22648>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by mjtamlyn):
* has_patch: 0 => 1
Comment:
Fixed in
https://github.com/mjtamlyn/django/commit/253ef84bcf3c10660941301f81e92d02e43886c6
--
Ticket URL: <https://code.djangoproject.com/ticket/22648#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Component: Database layer | Version: master
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"a2dd618e3b4a7472fab852da450ca5eef92a922f"]:
{{{
#!CommitTicketReference repository=""
revision="a2dd618e3b4a7472fab852da450ca5eef92a922f"
Fixed #22648 -- Transform.output_type should respect overridden
custom_lookup and custom_transform.
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22648#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Component: Database layer | Version: master
(models, ORM) | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by apollo13):
Needs backport to 1.7, also see the fix in
https://github.com/django/django/commit/5a2556afb9b1b3ef6e0622552970c67ac84ecd28
-- not sure if field_type should ever be None, please fix in the process
of backporting.
--
Ticket URL: <https://code.djangoproject.com/ticket/22648#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Component: Database layer | Version: master
(models, ORM) | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Marc Tamlyn <marc.tamlyn@…>):
In [changeset:"c38925a6018a7943936d1fd2b9038ab5de406545"]:
{{{
#!CommitTicketReference repository=""
revision="c38925a6018a7943936d1fd2b9038ab5de406545"
[1.7.x] Fixed #22648 -- Transform.output_type should respect overridden
custom_lookup and custom_transform.
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
Backport of a2dd618 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22648#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Component: Database layer | Version: master
(models, ORM) | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Marc Tamlyn <marc.tamlyn@…>):
In [changeset:"c38925a6018a7943936d1fd2b9038ab5de406545"]:
{{{
#!CommitTicketReference repository=""
revision="c38925a6018a7943936d1fd2b9038ab5de406545"
[1.7.x] Fixed #22648 -- Transform.output_type should respect overridden
custom_lookup and custom_transform.
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
Backport of a2dd618 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22648#comment:5>