[Django] #32934: Fix Admin's sidebar height to be dynamic based on visible header
Django
-----------------------------------------+------------------------
Reporter: gmjosack | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-----------------------------------------+------------------------
The current sticky nav bar on admin anchors past the page. If you have
long list of apps you have to scroll the whole page and then the nav to
get to the bottom.
Images, context, and patch available at
https://github.com/django/django/pull/14281
--
Ticket URL: <https://code.djangoproject.com/ticket/32934>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: gmjosack | Owner: gmjosack
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Jacob Walls):
* owner: nobody => gmjosack
* status: new => assigned
* stage: Unreviewed => Accepted
Comment:
Thanks -- accepting based on Tom's review of the
[https://github.com/django/django/pull/14281 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:1>
Django
Reporter: gary | Owner: gary
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 1
Changes (by Carlton Gibson):
* needs_better_patch: 0 => 1
Comment:
Current approach on PR is overly complex. A simpler CSS-only approach
should be feasible (?)
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:2>
Django
Reporter: gary | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Keywords: | Triage Stage: Accepted
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Carlton Gibson):
* owner: gary => (none)
* status: assigned => new
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:3>
Django
Reporter: gary | Owner:
| Hrushikesh Vaidya
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 1 | UI/UX: 1
Changes (by Hrushikesh Vaidya):
* owner: (none) => Hrushikesh Vaidya
* status: new => assigned
Comment:
A CSS only approach [https://github.com/django/django/pull/15234 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:4>
Django
Reporter: gary | Owner:
| Hrushikesh Vaidya
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:5>
Django
Reporter: gary | Owner:
| Hrushikesh Vaidya
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:6>
Django
Reporter: gary | Owner:
| Hrushikesh Vaidya
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => wontfix
* stage: Accepted => Unreviewed
Comment:
I'm going to resolve this as `wontfix`.
The scrolling issue doesn't seem that bad: the left sidebar pauses
independent scrolling at a point, scrolling in sync with the main section
until reaching the bottom (or either) after that, so it's not 100%
independent scrolling, but its ''OK''. Perhaps it's ''Just what browsers
do'', and given #32204 we have the filter in-place now too, it's a minor
glitch at worst.
In contrast the fixes are either too heavy
([https://github.com/django/django/pull/14281 PR14281]) or else have other
display issues ([https://github.com/django/django/pull/15234 PR15234]) and
so it's not clear there's a simple fix available (one that's really
justified by the issue). Pending such actually showing up, I don't further
effort here is the best use of time.
Happy to reopen to consider patches.
--
Ticket URL: <https://code.djangoproject.com/ticket/32934#comment:7>