[Django] #19925: Models validator should check if UserModel.REQUIRED_FIELDS is list
Django
----------------------------------------------+--------------------
Reporter: RomanAlexander | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
----------------------------------------------+--------------------
[https://github.com/django/django/pull/862 Pull request with patch here.]
I spent some time debugging django-admin.py createsuperuser raising
optparse.OptionConflictError.
I forgot to make REQUIRED_FIELDS custom user model a list. This validation
error should help others avoid my mistake.
--
Ticket URL: <https://code.djangoproject.com/ticket/19925>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: RomanAlexander | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by apollo13):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
Comment:
Sounds like a sensible addition.
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:1>
Django
Reporter: RomanAlexander | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
* cc: django@… (added)
Comment:
I created the pull request https://github.com/django/django/pull/876 to
fix this.
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:2>
Django
Reporter: RomanAlexander | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by streeter):
Crap, sorry, I just realized that there was another pull request by the
reporter as well. And it looks like we solved it just about the same way.
The only differences that I see are that I check that REQUIRED_FIELDS is a
list/tuple before checking that cls.USERNAME is not in the list, which may
be preferable. I also added tests for the change to the same places the
other two AUTH_USER_MODEL validation issues.
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:3>
Django
Reporter: RomanAlexander | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Database layer | Resolution: fixed
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"69373f3420d28597332a72269b5fae721cc6ae19"]:
{{{
#!CommitTicketReference repository=""
revision="69373f3420d28597332a72269b5fae721cc6ae19"
Fixed #19925 - Added validation for REQUIRED_FIELDS being a list
Thanks Roman Alexander for the suggestion.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:4>
Django
Reporter: RomanAlexander | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):
* needs_better_patch: 0 => 1
* component: Database layer (models, ORM) => contrib.admin
* needs_tests: 0 => 1
* keywords: => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* type: Cleanup/optimization => Uncategorized
* stage: Accepted => Unreviewed
Comment:
1
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:5>
Django
Reporter: RomanAlexander | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):
* needs_better_patch: 0 => 1
* component: Database layer (models, ORM) => contrib.admin
* needs_tests: 0 => 1
* keywords: => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* type: Cleanup/optimization => Uncategorized
* stage: Accepted => Unreviewed
Comment:
1
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:6>
Django
Reporter: RomanAlexander | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------
Comment (by ogpcludi <sample@…>):
1
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:7>
Django
Reporter: RomanAlexander | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------
Comment (by ogpcludi <sample@…>):
1
--
Ticket URL: <https://code.djangoproject.com/ticket/19925#comment:8>