[Django] #31864: Session data cannot be decoded during the transition to Django 3.1.

34 views
Skip to first unread message

Django

unread,
Aug 7, 2020, 1:06:30 AM8/7/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
--------------------------------------------+--------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.sessions | Version: 3.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+--------------------------
In d4fff711d4c97356bd6ba1273d2a5e349326eb5f (#31274) we've changed format
for session data, that's why setting `DEFAULT_HASHING_ALGORITHM` to
`'sha1'` is not enough to support running multiple instances of the same
project during the transition to Django 3.1.

We could use the legacy `encode()` when `DEFAULT_HASHING_ALGORITHM ==
'sha1'` (it's a bit hacky).

--
Ticket URL: <https://code.djangoproject.com/ticket/31864>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 7, 2020, 1:17:53 AM8/7/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
----------------------------------+--------------------------------------

Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.sessions | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by felixxm):

* cc: Markus Holtermann, Florian Apolloner, Carlton Gibson, אורי (added)
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/13279 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31864#comment:1>

Django

unread,
Aug 7, 2020, 1:44:20 AM8/7/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
----------------------------------+------------------------------------

Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.sessions | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31864#comment:2>

Django

unread,
Aug 7, 2020, 3:43:07 PM8/7/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
----------------------------------+------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: contrib.sessions | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"99abfe8f4d3caebcd73548f5bf9e4755bdfed318" 99abfe8]:
{{{
#!CommitTicketReference repository=""
revision="99abfe8f4d3caebcd73548f5bf9e4755bdfed318"
Fixed #31864 -- Fixed encoding session data during transition to Django
3.1.

Thanks אורי for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31864#comment:3>

Django

unread,
Aug 7, 2020, 3:44:39 PM8/7/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
----------------------------------+------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: contrib.sessions | Version: 3.1

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"c21bbe0883772ea91993eabac6c91ff575a81912" c21bbe08]:
{{{
#!CommitTicketReference repository=""
revision="c21bbe0883772ea91993eabac6c91ff575a81912"
[3.1.x] Fixed #31864 -- Fixed encoding session data during transition to
Django 3.1.

Thanks אורי for the report.

Backport of 99abfe8f4d3caebcd73548f5bf9e4755bdfed318 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31864#comment:4>

Django

unread,
Aug 8, 2020, 11:32:46 AM8/8/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
----------------------------------+------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: contrib.sessions | Version: 3.1

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Comment (by Carlton Gibson <carlton@…>):

In [changeset:"b2b0711b555fa292751763c2df4fe577c396f265" b2b0711b]:
{{{
#!CommitTicketReference repository=""
revision="b2b0711b555fa292751763c2df4fe577c396f265"
Refs #31864 -- Doc'd that DEFAULT_HASHING_ALGORITHM requires 3.1.1+ in
release notes.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31864#comment:5>

Django

unread,
Aug 8, 2020, 11:34:12 AM8/8/20
to django-...@googlegroups.com
#31864: Session data cannot be decoded during the transition to Django 3.1.
----------------------------------+------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: contrib.sessions | Version: 3.1

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Comment (by Carlton Gibson <carlton.gibson@…>):

In [changeset:"cdfdbb3411b7634ae119998a1d69801e1df275ff" cdfdbb34]:
{{{
#!CommitTicketReference repository=""
revision="cdfdbb3411b7634ae119998a1d69801e1df275ff"
[3.1.x] Refs #31864 -- Doc'd that DEFAULT_HASHING_ALGORITHM requires
3.1.1+ in release notes.

Backport of b2b0711b555fa292751763c2df4fe577c396f265 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31864#comment:6>

Reply all
Reply to author
Forward
0 new messages