Re: [Django] #34317: wrong attribute naming in method BaseModelFormSet.save_existing
Django
--------------------------------------+------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: Formset, ModelFomset | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
Hey Maxim, OK, yes. Where it's called the argument is `obj`, so +1 to
making it consistent.
Want to make the PR?
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: Formset, ModelFomset | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* owner: nobody => Bakdolot
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:3>
Django
--------------------------------------+------------------------------------
Reporter: Maxim Danilov | Owner: Bakdolot
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: Formset, ModelFomset | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Maxim Danilov):
Replying to [comment:2 Carlton Gibson]:
> Hey Maxim, OK, yes. Where it's called the argument is `obj`, so +1 to
making it consistent.
> Want to make the PR?
>
> Thanks.
Yes Carlton. I want to try to made it.
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:4>
Django
--------------------------------------+------------------------------------
Reporter: Maxim Danilov | Owner: Bakdolot
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: Formset, ModelFomset | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Bakdolot):
[https://github.com/django/django/pull/16529 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:5>
Django
Reporter: Maxim Danilov | Owner: Bakdolot
Cleanup/optimization |
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: Formset, | Triage Stage: Ready for
ModelFomset | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* version: 4.1 => dev
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Bakdolot
Cleanup/optimization |
Component: Forms | Version: dev
Keywords: Formset, | Triage Stage: Ready for
ModelFomset | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"5f3c7b7e1d059397e915bfa71409b49648b5d524" 5f3c7b7e]:
{{{
#!CommitTicketReference repository=""
revision="5f3c7b7e1d059397e915bfa71409b49648b5d524"
Fixed #34317 -- Renamed "instance" argument of
BaseModelFormSet.save_existing() method.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Bakdolot
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: dev
Severity: Normal | Resolution: fixed
Keywords: Formset, | Triage Stage: Ready for
ModelFomset | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Maxim Danilov):
Replying to [comment:7 GitHub <noreply@…>]:
> In [changeset:"5f3c7b7e1d059397e915bfa71409b49648b5d524" 5f3c7b7e]:
> {{{
> #!CommitTicketReference repository=""
revision="5f3c7b7e1d059397e915bfa71409b49648b5d524"
> Fixed #34317 -- Renamed "instance" argument of
BaseModelFormSet.save_existing() method.
> }}}
Mariusz Felisiak was faster than me :*-(
Thank you.
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Bakdolot
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: dev
Severity: Normal | Resolution: fixed
Keywords: Formset, | Triage Stage: Ready for
ModelFomset | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
> Mariusz Felisiak was faster than me :*-(
Not me, I only merged PR prepared by Bakdolot.
--
Ticket URL: <https://code.djangoproject.com/ticket/34317#comment:9>