Re: [Django] #1688: Permissions don't get translated in admin interface
Django
-------------------------------------+-------------------------------------
Reporter: Rudolph | Owner: hugo
Type: defect | Status: closed
Component: | Version: 1.2
Internationalization | Resolution: wontfix
Severity: normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by thepapermen):
* cc: thepapermen (added)
* ui_ux: => 0
* easy: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: defect | Status: closed
Component: | Version: 1.2
Internationalization |
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Thibaud Colas):
In case anyone follows updates here, link to a recent discussion about
this on the django-developers mailing list: https://groups.google.com/g
/django-developers/c/Jv1GqGlp3ao.
I have shared a proof of concept fixing this without changing the fact
that permission names are stored in the database, at least for default
permission names. And for all permissions, as far as I can see there’s no
reason to use the (untranslated) app name. Verbose app names are
translate-able and can just be switched to.
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Rudolph Froger | Owner: hugo
Type: defect | Status: closed
Component: | Version: 1.2
Internationalization |
Severity: normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
+1 from me to reopen if we have a way foward.
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Rudolph Froger | Owner: hugo
Type: defect | Status: closed
Component: | Version: 1.2
Internationalization |
Severity: normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Thibaud Colas):
🙌 as suggested by @nessita on Discord, I’ve taken this to the Django
Forum in Django Internals: https://forum.djangoproject.com/t/permissions-
dont-get-translated-in-admin-interface/21324.
Let’s try to keep the discussion going over there!
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:11>
Django
Reporter: Rudolph Froger | Owner: hugo
Component: Internationalization | Version: 1.2
Severity: normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by David Smith):
* status: closed => new
* has_patch: 1 => 0
* resolution: wontfix =>
* stage: Unreviewed => Accepted
Comment:
Re-opening following discussion both here and on the forum thread.
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:12>
Django
--------------------------------------+------------------------------------
Reporter: Rudolph Froger | Owner: hugo
Type: defect | Status: new
Component: Internationalization | Version: 1.2
Severity: normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Thibaud Colas):
I’m not 100% sure but I believe fixing this with the approach I suggested
in [https://github.com/thibaudcolas/django/pull/1 my PoC] would also fix
#26756. And possibly help with #27489.
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:13>
Django
--------------------------------------+------------------------------------
Reporter: Rudolph Froger | Owner: hugo
Type: defect | Status: new
Component: Internationalization | Version: 1.2
Severity: normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Natalia Bidart):
Replying to [comment:13 Thibaud Colas]:
> I’m not 100% sure but I believe fixing this with the approach I
suggested in [https://github.com/thibaudcolas/django/pull/1 my PoC] would
also fix #26756. And possibly help with #27489.
Would you have time to confirm whether that's the case? And, relatedly, I
don't have clarity on whether the linked PoC is in a "reviewable" state or
not. I wanna help, what would be the next useful step? Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:14>
Django
--------------------------------------+------------------------------------
Reporter: Rudolph Froger | Owner: hugo
Type: defect | Status: new
Component: Internationalization | Version: 1.2
Severity: normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Sebastian Rode):
I looked into #26756 as part of a Django sprint, it seems like the
underlying problem is the same. In both cases the verbose model_name is
written as permission.name to the database when creating it. This is not
updated when the verbose_name changes. The existing PR from a previous
author uses the migration plan to update the permission name explicitly
when any changes of verbose name happen. In my opinion the approach here
of not hard-coding the verbose model name to the database, is good, but
might have the potential of introducing breaking changes. I cannot really
judge this. Would be good to get some input.
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:15>
Django
Reporter: Rudolph Froger | Owner: Emme
| Bravo
Type: defect | Status: assigned
Component: | Version: 1.2
Internationalization |
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Thibaud Colas):
* owner: hugo => Emme Bravo
* status: new => assigned
Comment:
Yes Sebastian that’s right!
As part of Djangonaut Space, team Neptune worked on the prototype together
and we arrived at this new version:
[https://github.com/django/django/pull/18885
https://github.com/django/django/pull/18885]. This extends the previous
POC to demonstrate that this approach works even for custom permission
names (at least as far as we can tell so far).
Assigning to @emmebravo to take this from quick POC to a fully-fledged PR
with unit tests, docs changes and all.
---
As far as we could tell, though what’s described in #26756 would
technically still apply, the changes as part of ticket #1688 would make
#26756 any further changes redundant. And for #27489, I believe it
wouldn’t fix that ticket / might help a bit but not much.
--
Ticket URL: <https://code.djangoproject.com/ticket/1688#comment:16>