[Django] #28319: TextField form widget is being overridden when choices are specified.

2 views
Skip to first unread message

Django

unread,
Jun 17, 2017, 6:57:50 AM6/17/17
to django-...@googlegroups.com
#28319: TextField form widget is being overridden when choices are specified.
-------------------------------------+-------------------------------------
Reporter: Maciej | Owner: nobody
Jaworski |
Type: Bug | Status: new
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
When choices are specified on the field the form widget should be the
select one, for TextField some code overrides it to TextArea.

I've created a PR with a fix:
https://github.com/django/django/pull/8633

--
Ticket URL: <https://code.djangoproject.com/ticket/28319>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 17, 2017, 8:24:48 AM6/17/17
to django-...@googlegroups.com
#28319: Make TextField with choices use a Select widget
-------------------------------------+-------------------------------------
Reporter: Maciej Jaworski | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* component: Database layer (models, ORM) => Forms
* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28319#comment:1>

Django

unread,
Jun 17, 2017, 9:11:28 AM6/17/17
to django-...@googlegroups.com
#28319: Make TextField with choices use a Select widget
-------------------------------------+-------------------------------------
Reporter: Maciej Jaworski | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"dc63ad7ac09ef694f19ae1d7496367614889e6fd" dc63ad7a]:
{{{
#!CommitTicketReference repository=""
revision="dc63ad7ac09ef694f19ae1d7496367614889e6fd"
Fixed #28319 -- Made TextField with choices use a Select widget.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28319#comment:2>

Reply all
Reply to author
Forward
0 new messages