[Django] #34049: Admin - Scrollbar appears without overflowing content
Django
-------------------------------------------+--------------------------
Reporter: Durieux | Owner: Durieux
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-------------------------------------------+--------------------------
A scrollbar appears on the admin pages even if content is smaller than the
viewport.
This behavior is caused by an invisible SVG file used for the night mode
toggle sprite.
The SVG image is taking some space in the bottom of the page.
Adding a CSS rule to add `display: none` to the element appears to solve
the issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/34049>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Durieux | Owner: Durieux
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Durieux):
* has_patch: 0 => 1
Old description:
> A scrollbar appears on the admin pages even if content is smaller than
> the viewport.
>
> This behavior is caused by an invisible SVG file used for the night mode
> toggle sprite.
> The SVG image is taking some space in the bottom of the page.
>
> Adding a CSS rule to add `display: none` to the element appears to solve
> the issue.
New description:
A scrollbar appears on the admin pages even if content is smaller than the
viewport.
This behavior is caused by an invisible SVG file used for the night mode
toggle sprite.
The SVG image is taking some space in the bottom of the page.
Adding a CSS rule to add `display: none` to the element appears to solve
the issue.
Link to the PR: https://github.com/django/django/pull/16109
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34049#comment:1>
Django
---------------------------------+------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+------------------------------------
* stage: Unreviewed => Accepted
Comment:
Good catch!
Regression in bc7aa2a5e91cf65fc7510edaf1776528c7ad07b4.
--
Ticket URL: <https://code.djangoproject.com/ticket/34049#comment:2>
Django
Reporter: Durieux | Owner: Durieux
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34049#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Durieux | Owner: Durieux
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2905cbfd06794c31aa98713292bb506f24fa0aee" 2905cbfd]:
{{{
#!CommitTicketReference repository=""
revision="2905cbfd06794c31aa98713292bb506f24fa0aee"
Fixed #34049 -- Fixed displaying SVGs patterns.
Regression in bc7aa2a5e91cf65fc7510edaf1776528c7ad07b4.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34049#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Durieux | Owner: Durieux
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
I wonder if we should start using the `hidden` attribute instead of the
`display: none;` CSS directive.
--
Ticket URL: <https://code.djangoproject.com/ticket/34049#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Durieux | Owner: Durieux
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:5 Claude Paroz]:
> I wonder if we should start using the `hidden` attribute instead of the
`display: none;` CSS directive.
As far as I'm aware [https://developer.mozilla.org/en-
US/docs/Web/API/HTMLElement/hidden it depends where] we would like to use
it, but in this case `hidden` fits perfectly.
--
Ticket URL: <https://code.djangoproject.com/ticket/34049#comment:6>