[Django] #24324: makemigrations fails with UnicodeDecodeError when path to project contains special characters
Django
special characters
--------------------------------------------+--------------------
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
Component: Core (Management commands) | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------------+--------------------
Hi,
Checked on linux, python 2.7, with Django 1.7.4.
Steps to reproduce:
{{{
mktmpenv
pip install Django
cd /tmp/
mkdir hého
cd hého/
django-admin startproject project
cd project/
python manage.py startapp app
# add app to INSTALLED_APPS
# add model to app.models
python manage.py makemigrations app
}}}
Location:
{{{
django/db/migrations/writer.py", line 224, in path
return os.path.join(basedir, self.filename)
}}}
Root of the bug: just a mix of bytes and text:
{{{
>>> import os
>>> os.path.join(b'/tmp/hého', u'test')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6:
ordinal not in range(128)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by notsqrt):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
As a side-note, doing the following:
{{{
cd /tmp
mkdir éhé
cd éhé
git clone https://github.com/django/django/
cd tests
pip install -r requirements/py2.txt # this actually fails with pip < 6.0,
due to the accents
PYTHONPATH=..:$PYTHONPATH ./runtests.py
}}}
fails immediately ..
So there's probably a massive work to fix all problems..
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:1>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Normal | Resolution:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by notsqrt):
#19357 supposedly fixed all the problems in django 1.5, but I also found
that the template loader fails with non-ASCII path.
Down the rabbit hole !
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:2>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:3>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
Adding a patch that fixes the reported instance, but there seems to be
more work to do as the test suite still fails quite a bit.
To prevent future regressions, we could setup a Jenkins build with a name
that includes some non-ASCII character like "djangō".
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:4>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
When ojii and I maintained the previous iteration of the CI
infrastructure, we used a build name that contained a space and a non-
ASCII character in order to catch such issues.
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:5>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
Okay, I tried to setup a [http://djangoci.com/job/master-ἥoἥascii-path/
build with a nonascii path], but virtualenv has some problems with it.
Will look into that. Similarly, I encountered virtualenv problems with
spaces in the path when setting up the current CI machines.
[https://github.com/django/django/pull/4136 PR] to fix this ticket and
some related issues. 600+ test failures remain when running test suite on
a non-ascii path, but I guess it's probably only a handful of fixes.
Should we try to fix all these issues on 1.7?
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:6>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Comment:
I've added more commits to the PR and am down to
[http://dpaste.com/0C21E0G 8 failures on Python 2] on master.
Investigation continues tomorrow...
virtualenv 12.0.7 (latest as of now) still seems to have trouble with non-
ascii chars in the path: https://github.com/pypa/virtualenv/issues/457 so
I think we are out of look unless we add some exceptions to our normal
build script for the new build.
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:7>
Django
special characters
Reporter: notsqrt | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
Comment:
Tests are passing with [https://github.com/django/django/pull/4136 the
latest version of the patch].
As these issues are Python 2 only and no one has complained until five
months after the 1.7 release, I think we can skip fixing these issues
there (absent other opinions).
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:8>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: new => assigned
* owner: nobody => timgraham
* version: 1.7 => 1.8alpha1
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:9>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"4a0aeac1b5cfb7b6229a01119a596afb38d8a2a0"]:
{{{
#!CommitTicketReference repository=""
revision="4a0aeac1b5cfb7b6229a01119a596afb38d8a2a0"
Refs #24324 -- Fixed management command discovery on non-ASCII paths.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:10>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"bcb3bfa5a2716454e15ca0203e0debf497b14273"]:
{{{
#!CommitTicketReference repository=""
revision="bcb3bfa5a2716454e15ca0203e0debf497b14273"
[1.8.x] Refs #24324 -- Fixed management command discovery on non-ASCII
paths.
Backport of 4a0aeac1b5cfb7b6229a01119a596afb38d8a2a0 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:11>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"d316b43d0ab9db0f9913b094b84b11362d36d054"]:
{{{
#!CommitTicketReference repository=""
revision="d316b43d0ab9db0f9913b094b84b11362d36d054"
Refs #24324 -- Fixed UnicodeDecodeError in model_regress test on non-ASCII
path.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:12>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"b2f7daa4a6ba4f463dd79b19c337c738201479ad"]:
{{{
#!CommitTicketReference repository=""
revision="b2f7daa4a6ba4f463dd79b19c337c738201479ad"
[1.8.x] Refs #24324 -- Fixed UnicodeDecodeError in model_regress test on
non-ASCII path.
Backport of d316b43d0ab9db0f9913b094b84b11362d36d054 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:13>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"81a94cc616ab80decaa495cfa1c0c623527fc0e7"]:
{{{
#!CommitTicketReference repository=""
revision="81a94cc616ab80decaa495cfa1c0c623527fc0e7"
Refs #24324 -- Fixed makemessages crash when Django is installed in a non-
ASCII path.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:14>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"9dba901d9c44a117b35003e0c239476536c259aa"]:
{{{
#!CommitTicketReference repository=""
revision="9dba901d9c44a117b35003e0c239476536c259aa"
[1.8.x] Refs #24324 -- Fixed makemessages crash when Django is installed
in a non-ASCII path.
Backport of 81a94cc616ab80decaa495cfa1c0c623527fc0e7 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:15>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"63c5c9870129f6b81358c1ed7ed2392bbc46f77d"]:
{{{
#!CommitTicketReference repository=""
revision="63c5c9870129f6b81358c1ed7ed2392bbc46f77d"
Refs #24324 -- Fixed UnicodeEncodeError in SQLite backend while testing.
If 'name' contained non-ASCII characters, the comparison raised a
UnicodeEncodeError on Python 2.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:16>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"4f43e5c4353325eb8d1c455c58e299ef95e2e422"]:
{{{
#!CommitTicketReference repository=""
revision="4f43e5c4353325eb8d1c455c58e299ef95e2e422"
[1.8.x] Refs #24324 -- Fixed UnicodeEncodeError in SQLite backend while
testing.
If 'name' contained non-ASCII characters, the comparison raised a
UnicodeEncodeError on Python 2.
Backport of 63c5c9870129f6b81358c1ed7ed2392bbc46f77d from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:17>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"c9ece2e6b9365fa4be16bd0de25dd7b68c8dc97e"]:
{{{
#!CommitTicketReference repository=""
revision="c9ece2e6b9365fa4be16bd0de25dd7b68c8dc97e"
Refs #24324 -- Fixed UnicodeDecodeError in makemigrations.
If the project path contained a non-ASCII character, Python 2 crashed.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:18>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"ba3a7636f1bb8c02eaabbeff9a3731ad27a82c5d"]:
{{{
#!CommitTicketReference repository=""
revision="ba3a7636f1bb8c02eaabbeff9a3731ad27a82c5d"
[1.8.x] Refs #24324 -- Fixed UnicodeDecodeError in makemigrations.
If the project path contained a non-ASCII character, Python 2 crashed.
Backport of c9ece2e6b9365fa4be16bd0de25dd7b68c8dc97e from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:19>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"bad6280c4e3f75f3ccd27f8fd85a4043bb296128"]:
{{{
#!CommitTicketReference repository=""
revision="bad6280c4e3f75f3ccd27f8fd85a4043bb296128"
Refs #24324 -- Fixed get_app_template_dirs() UnicodeDecodeError on Python
2.
The function implemented most of upath(), but skipped the check for
strings that are already unicode.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:20>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a1fa0135ecb28911f31af4df994be26db59355e4"]:
{{{
#!CommitTicketReference repository=""
revision="a1fa0135ecb28911f31af4df994be26db59355e4"
[1.8.x] Refs #24324 -- Fixed get_app_template_dirs() UnicodeDecodeError on
Python 2.
The function implemented most of upath(), but skipped the check for
strings that are already unicode.
Backport of bad6280c4e3f75f3ccd27f8fd85a4043bb296128 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:21>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"bebc1e53a3ab059849e5c4e5a55b2f5e68b67169"]:
{{{
#!CommitTicketReference repository=""
revision="bebc1e53a3ab059849e5c4e5a55b2f5e68b67169"
Refs #24324 -- Fixed UnicodeDecodeError in template_backends tests
The message for the SuspiciousFileOperation exception needs to
be a unicode string.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:22>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"fa66ea75326e669cd3d51fb926a4364b8ba08959"]:
{{{
#!CommitTicketReference repository=""
revision="fa66ea75326e669cd3d51fb926a4364b8ba08959"
Refs #24324 -- Fixed UnicodeDecodeError in MigrationWriter on Python 2.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:23>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"f9a99c410e4ccc2ca89fc6006c48a23b02bae873"]:
{{{
#!CommitTicketReference repository=""
revision="f9a99c410e4ccc2ca89fc6006c48a23b02bae873"
[1.8.x] Refs #24324 -- Fixed UnicodeDecodeError in template_backends tests
The message for the SuspiciousFileOperation exception needs to
be a unicode string.
Backport of bebc1e53a3ab059849e5c4e5a55b2f5e68b67169 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:24>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"09da1b465ea8ba9ecb99b1cd02a689bb831d0e1b"]:
{{{
#!CommitTicketReference repository=""
revision="09da1b465ea8ba9ecb99b1cd02a689bb831d0e1b"
[1.8.x] Refs #24324 -- Fixed UnicodeDecodeError in MigrationWriter on
Python 2.
Backport of fa66ea75326e669cd3d51fb926a4364b8ba08959 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:25>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"307c0f299a6c26f5231d3516df5b4edc54b36553"]:
{{{
#!CommitTicketReference repository=""
revision="307c0f299a6c26f5231d3516df5b4edc54b36553"
Refs #24324 -- Fixed Python 2 test failures when path to Django source
contains non-ASCII characters.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:26>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"2aa06e439a29a1c24fa03744395cc57787e7198e"]:
{{{
#!CommitTicketReference repository=""
revision="2aa06e439a29a1c24fa03744395cc57787e7198e"
[1.8.x] Refs #24324 -- Fixed Python 2 test failures when path to Django
source contains non-ASCII characters.
Backport of 307c0f299a6c26f5231d3516df5b4edc54b36553 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:27>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"b8d6cdbcc90ff8af781d13131b79ce88a9eff66d"]:
{{{
#!CommitTicketReference repository=""
revision="b8d6cdbcc90ff8af781d13131b79ce88a9eff66d"
Refs #24324 -- Skipped fixtures_regress tests that fail on Python 2 on a
non-ASCII path.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:29>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"098fa12dd390e733c7568d824eea2c346550c75a"]:
{{{
#!CommitTicketReference repository=""
revision="098fa12dd390e733c7568d824eea2c346550c75a"
Refs #24324 -- Fixed crash in {% debug %} tag on Python 2.
If Django is installed in a path that contains non-ASCII characters,
the tag failed with UnicodeDecodeError.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:28>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"1153bccc1bc654a547a310d0614b989606d25950"]:
{{{
#!CommitTicketReference repository=""
revision="1153bccc1bc654a547a310d0614b989606d25950"
[1.8.x] Refs #24324 -- Fixed crash in {% debug %} tag on Python 2.
If Django is installed in a path that contains non-ASCII characters,
the tag failed with UnicodeDecodeError.
Backport of 098fa12dd390e733c7568d824eea2c346550c75a from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:30>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Type: Bug | Status: assigned
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"5068a51d88a7084bd0349d150816fc6041caa224"]:
{{{
#!CommitTicketReference repository=""
revision="5068a51d88a7084bd0349d150816fc6041caa224"
[1.8.x] Refs #24324 -- Skipped fixtures_regress tests that fail on Python
2 on a non-ASCII path.
Backport of b8d6cdbcc90ff8af781d13131b79ce88a9eff66d from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:31>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Component: Core (Management | Version: 1.8alpha1
commands) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
Had trouble on the Jenkins build on Python 2 when running `./runtests.py`:
{{{
Traceback (most recent call last):
File "./runtests.py", line 431, in <module>
options.debug_sql)
File "./runtests.py", line 253, in django_tests
extra_tests=extra_tests,
File "/home/jenkins/workspace/master-ἥoἥascii-
path/database/sqlite3/label/trusty/python/python2.7/django/test/runner.py",
line 209, in run_tests
suite = self.build_suite(test_labels, extra_tests)
File "/home/jenkins/workspace/master-ἥoἥascii-
path/database/sqlite3/label/trusty/python/python2.7/django/test/runner.py",
line 150, in build_suite
tests = self.test_loader.discover(start_dir=label, **kwargs)
File "/usr/lib/python2.7/unittest/loader.py", line 206, in discover
tests = list(self._find_tests(start_dir, pattern))
File "/usr/lib/python2.7/unittest/loader.py", line 267, in _find_tests
raise ImportError(msg % (mod_name, module_dir, expected_dir))
ImportError: u'tests' module incorrectly imported from
'/home/jenkins/workspace/master-\xe1\xbc\xa5o\xe1\xbc\xa5ascii-
path/database/sqlite3/label/trusty/python/python2.7/tests/shortcuts'.
Expected u'/home/jenkins/workspace/master-\u1f25o\u1f25ascii-
path/database/sqlite3/label/trusty/python/python2.7/tests/shortcuts'. Is
this module globally installed?
}}}
but `./tests/runtests.py` works so I'm using a different build script for
[http://djangoci.com/view/All/job/master-%E1%BC%A5o%E1%BC%A5ascii-path/
the build] with that invocation (and also using a different virtualenv
path so we avoid the non-ASCII chars). It's green now!
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:32>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Component: Core (Management | Version: 1.8alpha1
commands) |
Severity: Release blocker | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: closed => new
* resolution: fixed =>
Comment:
I don't think the solution to the problem should be "Just don't use
nonascii characters in path names".
I'm not totally sure, but I suppose the problem is the `unicode_literals`
future import.
See Armin's opinion here: https://github.com/PythonCharmers/python-
future/issues/22
I got a traceback like this:
{{{
a = '/var/lib/jenkins/jobs/K\xc3\xa1rtyarendel\xc5\x91/workspace/orders'
p = ('management.py',)
path =
'/var/lib/jenkins/jobs/K\xc3\xa1rtyarendel\xc5\x91/workspace/orders'
b = 'management.py'
def join(a, *p):
"""Join two or more pathname components, inserting '/' as needed.
If any component is an absolute path, all previous path components
will be discarded. An empty last part will result in a path that
ends with a separator."""
path = a
for b in p:
if b.startswith('/'):
path = b
elif path == '' or path.endswith('/'):
path += b
else:
> path += '/' + b
E UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3
in position 23: ordinal not in range(128)
/usr/lib64/python2.7/posixpath.py:80: UnicodeDecodeError
}}}
As far as I understand ``os.path.join`` can't handle unicode inputs, but
when you use the `unicode_literals`, everything will be unicode.
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:33>
Django
character
-------------------------------------+-------------------------------------
Reporter: notsqrt | Owner: timgraham
Component: Core (Management | Version: 1.8
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* version: 1.8alpha1 => 1.8
* resolution: => fixed
Comment:
The issue reported in this ticket is fixed in Django 1.8. Please open a
new bug with steps to reproduce if you are encountering a different issue.
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/24324#comment:34>