[Django] #27136: Change auth forms' autofocus attribute to HTML5 boolean syntax
Django
------------------------------------------------+------------------------
Reporter: jdufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Similar to #26928.
The autofocus attribute in auth forms is rendered as `autofocus=""`, but
it could be rendered as an HTML5 boolean attribute `autofocus`. As docs
now state Django HTML specifically targets HTML5, might as well use the
boolean syntax for all boolean attributes.
Example attribute:
https://github.com/django/django/blob/38cf9ef390eb0cd0703d99893f826153865f6ba6/django/contrib/auth/forms.py#L98
--
Ticket URL: <https://code.djangoproject.com/ticket/27136>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jdufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
* stage: Unreviewed => Ready for checkin
Comment:
[https://github.com/django/django/pull/7164 PR] looks good. I'm not sure
it merits a release note.
--
Ticket URL: <https://code.djangoproject.com/ticket/27136#comment:1>
Django
Reporter: jdufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
I would also for not bloating the release notes with such "details".
--
Ticket URL: <https://code.djangoproject.com/ticket/27136#comment:2>
Django
Reporter: jdufresne | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"ae98d40c358af2e14bac03d9a3a2dc99701aa13a" ae98d40c]:
{{{
#!CommitTicketReference repository=""
revision="ae98d40c358af2e14bac03d9a3a2dc99701aa13a"
Fixed #27136 -- Changed auth forms' autofocus attribute to HTML5 boolean
syntax.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27136#comment:3>