[Django] #29349: Improve documentation regarding allow_relation

15 views
Skip to first unread message

Django

unread,
Apr 21, 2018, 9:35:19 AM4/21/18
to django-...@googlegroups.com
#29349: Improve documentation regarding allow_relation
------------------------------------------------+------------------------
Reporter: Stefan R. Filipek | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The documentation is not clear what happens when all routers return None
from allow_relation.

The default behavior is to only allow relations within the same database.
To allow cross-database relations, some router must return True.

--
Ticket URL: <https://code.djangoproject.com/ticket/29349>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 21, 2018, 9:35:31 AM4/21/18
to django-...@googlegroups.com
#29349: Improve documentation regarding allow_relation
-------------------------------------+-------------------------------------
Reporter: Stefan R. Filipek | Owner: Stefan R.
Type: | Filipek
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Stefan R. Filipek):

* owner: nobody => Stefan R. Filipek
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/29349#comment:1>

Django

unread,
Apr 21, 2018, 9:46:54 AM4/21/18
to django-...@googlegroups.com
#29349: Improve documentation regarding allow_relation
-------------------------------------+-------------------------------------
Reporter: Stefan R. Filipek | Owner: Stefan R.
Type: | Filipek
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Stefan R. Filipek):

* has_patch: 0 => 1


Comment:

Pull request: https://github.com/django/django/pull/9893

--
Ticket URL: <https://code.djangoproject.com/ticket/29349#comment:2>

Django

unread,
Apr 22, 2018, 9:23:12 PM4/22/18
to django-...@googlegroups.com
#29349: Document that database routing disallows cross-database relations by
default

-------------------------------------+-------------------------------------
Reporter: Stefan R. Filipek | Owner: Stefan R.
Type: | Filipek
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29349#comment:3>

Django

unread,
Apr 23, 2018, 11:45:25 AM4/23/18
to django-...@googlegroups.com
#29349: Document that database routing disallows cross-database relations by
default
-------------------------------------+-------------------------------------
Reporter: Stefan R. Filipek | Owner: Stefan R.
Type: | Filipek
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"9ec77f3d6633691c9bbf31d10af2313689170c85" 9ec77f3d]:
{{{
#!CommitTicketReference repository=""
revision="9ec77f3d6633691c9bbf31d10af2313689170c85"
Fixed #29349 -- Doc'd the default behavior of router.allow_relation().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29349#comment:4>

Django

unread,
Apr 24, 2018, 11:23:19 AM4/24/18
to django-...@googlegroups.com
#29349: Document that database routing disallows cross-database relations by
default
-------------------------------------+-------------------------------------
Reporter: Stefan R. Filipek | Owner: Stefan R.
Type: | Filipek
Cleanup/optimization | Status: closed
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"9f2586b96486d13e5d9bbcfb6fe6836f989f79dc" 9f2586b]:
{{{
#!CommitTicketReference repository=""
revision="9f2586b96486d13e5d9bbcfb6fe6836f989f79dc"
[2.0.x] Fixed #29349 -- Doc'd the default behavior of
router.allow_relation().

Backport of 9ec77f3d6633691c9bbf31d10af2313689170c85 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29349#comment:5>

Reply all
Reply to author
Forward
0 new messages