[Django] #31821: Confusing documentation for FILE_UPLOAD_PERMISSIONS

25 views
Skip to first unread message

Django

unread,
Jul 23, 2020, 6:04:34 AM7/23/20
to django-...@googlegroups.com
#31821: Confusing documentation for FILE_UPLOAD_PERMISSIONS
-------------------------------------+-------------------------------------
Reporter: dqd | Owner: nobody
Type: Bug | Status: new
Component: | Version: master
Documentation | Keywords:
Severity: Normal | FILE_UPLOAD_PERMISSIONS
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
The current documentation for `FILE_UPLOAD_PERMISSIONS`
(https://docs.djangoproject.com/en/dev/ref/settings/#std:setting-
FILE_UPLOAD_PERMISSIONS) states two contradicting pieces of information:
* The default value of `FILE_UPLOAD_PERMISSIONS` is `0o644`.
* If ''this isn’t given'' or is None, you’ll get operating-system
dependent behavior.

It seems that after changing the default value in #30004, the part stating
"this isn’t given" is no longer valid and should be removed.

--
Ticket URL: <https://code.djangoproject.com/ticket/31821>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 23, 2020, 8:08:37 AM7/23/20
to django-...@googlegroups.com
#31821: Confusing documentation for FILE_UPLOAD_PERMISSIONS
-------------------------------------+-------------------------------------
Reporter: Pavel Mises | Owner: Harpreet
| Sharma
Type: Bug | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FILE_UPLOAD_PERMISSIONS | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Harpreet Sharma):

* owner: nobody => Harpreet Sharma
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/31821#comment:1>

Django

unread,
Jul 23, 2020, 9:13:35 AM7/23/20
to django-...@googlegroups.com
#31821: FILE_UPLOAD_PERMISSIONS docs contain outdated note.

-------------------------------------+-------------------------------------
Reporter: Pavel Mises | Owner: Harpreet
Type: | Sharma
Cleanup/optimization | Status: assigned

Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FILE_UPLOAD_PERMISSIONS |
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31821#comment:2>

Django

unread,
Jul 23, 2020, 1:45:53 PM7/23/20
to django-...@googlegroups.com
#31821: FILE_UPLOAD_PERMISSIONS docs contain outdated note.
-------------------------------------+-------------------------------------
Reporter: Pavel Mises | Owner: Harpreet
Type: | Sharma
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FILE_UPLOAD_PERMISSIONS |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Harpreet Sharma):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/13231

--
Ticket URL: <https://code.djangoproject.com/ticket/31821#comment:3>

Django

unread,
Jul 23, 2020, 3:00:54 PM7/23/20
to django-...@googlegroups.com
#31821: FILE_UPLOAD_PERMISSIONS docs contain outdated note.
-------------------------------------+-------------------------------------
Reporter: Pavel Mises | Owner: Harpreet
Type: | Sharma
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
FILE_UPLOAD_PERMISSIONS |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"248d03fbe932b0844c628e56dafba334f9e028e4" 248d03fb]:
{{{
#!CommitTicketReference repository=""
revision="248d03fbe932b0844c628e56dafba334f9e028e4"
Fixed #31821 -- Removed outdated note in FILE_UPLOAD_PERMISSIONS docs.

Follow up to 22aab8662f0368b63f91f2526bdd0532524bc0fe
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31821#comment:4>

Django

unread,
Jul 23, 2020, 3:02:00 PM7/23/20
to django-...@googlegroups.com
#31821: FILE_UPLOAD_PERMISSIONS docs contain outdated note.
-------------------------------------+-------------------------------------
Reporter: Pavel Mises | Owner: Harpreet
Type: | Sharma
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
FILE_UPLOAD_PERMISSIONS |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"08063f0122ce58ecb00ee94f0ca78a42df0b0af2" 08063f0]:
{{{
#!CommitTicketReference repository=""
revision="08063f0122ce58ecb00ee94f0ca78a42df0b0af2"
[3.0.x] Fixed #31821 -- Removed outdated note in FILE_UPLOAD_PERMISSIONS
docs.

Follow up to 22aab8662f0368b63f91f2526bdd0532524bc0fe

Backport of 248d03fbe932b0844c628e56dafba334f9e028e4 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31821#comment:5>

Django

unread,
Jul 28, 2020, 5:55:59 AM7/28/20
to django-...@googlegroups.com
#31821: FILE_UPLOAD_PERMISSIONS docs contain outdated note.
-------------------------------------+-------------------------------------
Reporter: Pavel Mises | Owner: Harpreet
Type: | Sharma
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
FILE_UPLOAD_PERMISSIONS |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"31164445599d8c1e69147485e418c6acc67e1278" 3116444]:
{{{
#!CommitTicketReference repository=""
revision="31164445599d8c1e69147485e418c6acc67e1278"
[3.1.x] Fixed #31821 -- Removed outdated note in FILE_UPLOAD_PERMISSIONS
docs.

Follow up to 22aab8662f0368b63f91f2526bdd0532524bc0fe

Backport of 248d03fbe932b0844c628e56dafba334f9e028e4 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31821#comment:6>

Reply all
Reply to author
Forward
0 new messages