Re: [Django] #35159: dumpdata crashes on querysets with prefetch_related().

15 views
Skip to first unread message

Django

unread,
Jan 31, 2024, 3:13:45 AM1/31/24
to django-...@googlegroups.com
#35159: dumpdata crashes on querysets with prefetch_related().
-------------------------------------+-------------------------------------
Reporter: Andrea F | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Core (Management | Version: 5.0
commands) |
Severity: Release blocker | Resolution:
Keywords: dumpdata chunk_size | Triage Stage: Accepted
iterator prefetch_related |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: yushan => Mariusz Felisiak

--
Ticket URL: <https://code.djangoproject.com/ticket/35159#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 31, 2024, 3:21:10 AM1/31/24
to django-...@googlegroups.com
#35159: dumpdata crashes on querysets with prefetch_related().
-------------------------------------+-------------------------------------
Reporter: Andrea F | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Core (Management | Version: 5.0
commands) |
Severity: Release blocker | Resolution:
Keywords: dumpdata chunk_size | Triage Stage: Accepted
iterator prefetch_related |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):

[https://github.com/django/django/pull/17801 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35159#comment:4>

Django

unread,
Jan 31, 2024, 3:21:17 AM1/31/24
to django-...@googlegroups.com
#35159: dumpdata crashes on querysets with prefetch_related().
-------------------------------------+-------------------------------------
Reporter: Andrea F | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Core (Management | Version: 5.0
commands) |
Severity: Release blocker | Resolution:
Keywords: dumpdata chunk_size | Triage Stage: Accepted
iterator prefetch_related |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35159#comment:5>

Django

unread,
Jan 31, 2024, 10:10:18 AM1/31/24
to django-...@googlegroups.com
#35159: dumpdata crashes on querysets with prefetch_related().
-------------------------------------+-------------------------------------
Reporter: Andrea F | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed

Component: Core (Management | Version: 5.0
commands) |
Severity: Release blocker | Resolution: fixed

Keywords: dumpdata chunk_size | Triage Stage: Accepted
iterator prefetch_related |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"38eaf2f21a2398a8dd8444f6df3723898cb5fe2a" 38eaf2f2]:
{{{#!CommitTicketReference repository=""
revision="38eaf2f21a2398a8dd8444f6df3723898cb5fe2a"
Fixed #35159 -- Fixed dumpdata crash when base querysets use
prefetch_related().

Regression in 139135627650ed6aaaf4c755b82c3bd43f2b8f51
following deprecation in edbf930287cb72e9afab1f7208c24b1146b0c4ec.

Thanks Andrea F for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35159#comment:6>

Django

unread,
Jan 31, 2024, 10:11:28 AM1/31/24
to django-...@googlegroups.com
#35159: dumpdata crashes on querysets with prefetch_related().
-------------------------------------+-------------------------------------
Reporter: Andrea F | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Core (Management | Version: 5.0
commands) |
Severity: Release blocker | Resolution: fixed
Keywords: dumpdata chunk_size | Triage Stage: Accepted
iterator prefetch_related |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"7453d6a80792e3f811fc662b8b25fdcbc5ea7eb3" 7453d6a]:
{{{#!CommitTicketReference repository=""
revision="7453d6a80792e3f811fc662b8b25fdcbc5ea7eb3"
[5.0.x] Fixed #35159 -- Fixed dumpdata crash when base querysets use
prefetch_related().

Regression in 139135627650ed6aaaf4c755b82c3bd43f2b8f51
following deprecation in edbf930287cb72e9afab1f7208c24b1146b0c4ec.

Thanks Andrea F for the report.

Backport of 38eaf2f21a2398a8dd8444f6df3723898cb5fe2a from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35159#comment:7>

Reply all
Reply to author
Forward
0 new messages