[Django] #22016: Automatically reload i18n files on change, when DEBUG is True

18 views
Skip to first unread message

Django

unread,
Feb 11, 2014, 1:22:05 PM2/11/14
to django-...@googlegroups.com
#22016: Automatically reload i18n files on change, when DEBUG is True
--------------------------------------+----------------------
Reporter: vegitron | Owner: vegitron
Type: New feature | Status: new
Component: Internationalization | Version:
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+----------------------
It would make things easier for our text editors if they didn't need to
run compilemessages to see their changes on their builds. This would need
to cover python translation, templates, and the javascript catalog. This
would create parity between seeing text changes and seeing python changes.

This is similar to #9523, only I'd like to have a check for compilation
when translations are used.

I have a patch that has unit tests, and implements changes in trans_real
and in the javascript_catalog. I'll send a pull request after my CCLA is
sent in.

--
Ticket URL: <https://code.djangoproject.com/ticket/22016>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 11, 2014, 2:09:49 PM2/11/14
to django-...@googlegroups.com
#22016: Automatically reload i18n files on change, when DEBUG is True
-------------------------------------+-------------------------------------

Reporter: vegitron | Owner: vegitron
Type: New feature | Status: new
Component: | Version:
Internationalization | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by vegitron):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Branch is at https://github.com/vegitron/django/tree/ticket_22016

--
Ticket URL: <https://code.djangoproject.com/ticket/22016#comment:1>

Django

unread,
Apr 29, 2014, 8:30:11 AM4/29/14
to django-...@googlegroups.com
#22016: Automatically reload i18n files on change, when DEBUG is True
--------------------------------------+------------------------------------

Reporter: vegitron | Owner: vegitron
Type: New feature | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timo):

* version: => master
* stage: Unreviewed => Accepted


Comment:

I'm not very familiar with translations, but this seems like a reasonable
request.

--
Ticket URL: <https://code.djangoproject.com/ticket/22016#comment:2>

Django

unread,
Aug 3, 2014, 7:40:38 AM8/3/14
to django-...@googlegroups.com
#22016: Automatically reload i18n files on change, when DEBUG is True
--------------------------------------+------------------------------------

Reporter: vegitron | Owner: vegitron
Type: New feature | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by merb):

* needs_better_patch: 0 => 1


Comment:

you forget to link the PR: https://github.com/django/django/pull/2421
Currently your patch needs to be updated, could you do that?

Also it would be great if you add some small docstrings to your tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/22016#comment:3>

Django

unread,
Apr 3, 2016, 5:17:53 AM4/3/16
to django-...@googlegroups.com
#22016: Automatically reload i18n files on change, when DEBUG is True
--------------------------------------+------------------------------------

Reporter: vegitron | Owner: vegitron
Type: New feature | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by sergeykolosov):

* cc: m17.admin@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/22016#comment:4>

Django

unread,
Jan 29, 2020, 12:32:59 AM1/29/20
to django-...@googlegroups.com
#22016: Automatically reload i18n files on change, when DEBUG is True
-------------------------------------+-------------------------------------
Reporter: Patrick Michaud | Owner: Patrick
| Michaud

Type: New feature | Status: new
Component: | Version: master
Internationalization |

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Rodrigo):

With the current code base, this can be achieved by adding the .po suffix
for watching in
https://github.com/django/django/blob/master/django/utils/translation/reloader.py,
and then compile it.

However, the .po suffix seems to been explicitly left out, perhaps there
is not a consensus in this behavior for every workflow.

This seems straightforward to implement at this moment, can someone
confirm this?

--
Ticket URL: <https://code.djangoproject.com/ticket/22016#comment:5>

Reply all
Reply to author
Forward
0 new messages