[Django] #22835: Deprecate NoArgsCommand
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core | Keywords:
(Management commands) | Has patch: 0
Severity: Normal | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Now that management command parsing is done through argparse, the
`NoArgsCommand` is not especially useful, as with argparse, no arguments
are accepted by default except when specified by `add_argument`.
--
Ticket URL: <https://code.djangoproject.com/ticket/22835>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by maxocub):
* owner: nobody => maxocub
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by maxocub):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by maxocub):
Here's my [https://github.com/django/django/pull/2826 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Management | Resolution:
commands) | Triage Stage: Ready for
Severity: Normal | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by claudep):
* stage: Accepted => Ready for checkin
Comment:
Looks good to me.
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Has patch: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Left some cosmetic comments but `staticfiles_tests` are also failing.
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by maxocub):
I have updated my [https://github.com/django/django/pull/2826 PR] so the
staticfiles_tests won't fail anymore.
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Management | Resolution: fixed
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9996158db467f9bef8243fcc36dc3602570e3613"]:
{{{
#!CommitTicketReference repository=""
revision="9996158db467f9bef8243fcc36dc3602570e3613"
Fixed #22835 -- Deprecated NoArgsCommand.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Management | Resolution: fixed
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: maxocub
Type: | Status: closed
Cleanup/optimization |
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"b4002a214399d8619965f40e153ca3f7dcb20904" b4002a2]:
{{{
#!CommitTicketReference repository=""
revision="b4002a214399d8619965f40e153ca3f7dcb20904"
Refs #22835 -- Removed NoArgsCommand per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22835#comment:9>