[Django] #27873: Don't assume that ALLOWED_HOSTS is a list

[Django]

#27873: Don't assume that ALLOWED_HOSTS is a list
-----------------------------------------+------------------------
Reporter: Chris Lamb | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
We previously let ALLOWED_HOSTS to be a tuple but 17e6616 (re. #26666)
regressed on this.

--
Ticket URL: <https://code.djangoproject.com/ticket/27873>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#27873: Don't assume that ALLOWED_HOSTS is a list

-------------------------------+--------------------------------------

Reporter: Chris Lamb | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11

Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+--------------------------------------

Comment (by Chris Lamb):

https://github.com/django/django/pull/8101

--
Ticket URL: <https://code.djangoproject.com/ticket/27873#comment:1>

[Django]

#27873: setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple
-----------------------------------+------------------------------------

Reporter: Chris Lamb | Owner: nobody

Type: Bug | Status: new
Component: Testing framework | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-----------------------------------+------------------------------------
Changes (by Tim Graham):

* component: Uncategorized => Testing framework
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
* type: Uncategorized => Bug
* severity: Normal => Release blocker

Old description:

> We previously let ALLOWED_HOSTS to be a tuple but 17e6616 (re. #26666)
> regressed on this.

New description:

We previously let ALLOWED_HOSTS to be a tuple but [17e6616] (re. #26666)
regressed on this.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/27873#comment:2>

[Django]

#27873: setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple
-----------------------------------+------------------------------------

Reporter: Chris Lamb | Owner: nobody

Type: Bug | Status: new
Component: Testing framework | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-----------------------------------+------------------------------------

Comment (by Chris Lamb):

[https://github.com/django/django/pull/8101 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27873#comment:3>

[Django]

#27873: setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple
-----------------------------------+------------------------------------

Reporter: Chris Lamb | Owner: nobody

Type: Bug | Status: new
Component: Testing framework | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+------------------------------------
Changes (by Chris Lamb):

* needs_tests: 1 => 0

Comment:

[https://github.com/django/django/pull/8101#issuecomment-282192871 PR
updated with tests]

--
Ticket URL: <https://code.djangoproject.com/ticket/27873#comment:4>

[Django]

#27873: setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple
-----------------------------------+------------------------------------

Reporter: Chris Lamb | Owner: nobody

Type: Bug | Status: closed

Component: Testing framework | Version: 1.11

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"339d526d55baffea3bd3cecd0e07ddf644028e8c" 339d526d]:
{{{
#!CommitTicketReference repository=""
revision="339d526d55baffea3bd3cecd0e07ddf644028e8c"
Fixed #27873 -- Fixed crash in setup_test_environment() if ALLOWED_HOSTS
is a tuple.

Regression in 17e661641ddaf8266e7430d83cfb2039abc55df7
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27873#comment:5>

[Django]

#27873: setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple
-----------------------------------+------------------------------------

Reporter: Chris Lamb | Owner: nobody

Type: Bug | Status: closed
Component: Testing framework | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"5a85f2ca5fc3c4292cd1b147198d75d0f141fd71" 5a85f2c]:
{{{
#!CommitTicketReference repository=""
revision="5a85f2ca5fc3c4292cd1b147198d75d0f141fd71"
[1.11.x] Fixed #27873 -- Fixed crash in setup_test_environment() if
ALLOWED_HOSTS is a tuple.

Regression in 17e661641ddaf8266e7430d83cfb2039abc55df7

Backport of 339d526d55baffea3bd3cecd0e07ddf644028e8c from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27873#comment:6>