Re: [Django] #34291: Validation of UniqueConstraint with ordered expressions crashes.

13 views
Skip to first unread message

Django

unread,
Jan 25, 2023, 8:31:48 AM1/25/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Dan F):

Thanks for the quick review!

Replying to [comment:2 Mariusz Felisiak]:
> Thanks for the report!

--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 26, 2023, 12:32:07 AM1/26/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned

Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:4>

Django

unread,
Jan 26, 2023, 12:50:00 AM1/26/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/16501 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:5>

Django

unread,
Jan 26, 2023, 3:07:03 AM1/26/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:6>

Django

unread,
Jan 26, 2023, 3:31:58 AM1/26/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed

Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"2b1242abb3989f5d74e787b09132d01bcbee5b55" 2b1242a]:
{{{
#!CommitTicketReference repository=""
revision="2b1242abb3989f5d74e787b09132d01bcbee5b55"
Fixed #34291 -- Fixed Meta.constraints validation crash on
UniqueConstraint with ordered expressions.

Thanks Dan F for the report.

Bug in 667105877e6723c6985399803a364848891513cc.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:7>

Django

unread,
Jan 26, 2023, 3:32:43 AM1/26/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"719a14badcd226732c9c1172f8183e5f42e54241" 719a14ba]:
{{{
#!CommitTicketReference repository=""
revision="719a14badcd226732c9c1172f8183e5f42e54241"
[4.2.x] Fixed #34291 -- Fixed Meta.constraints validation crash on
UniqueConstraint with ordered expressions.

Thanks Dan F for the report.

Bug in 667105877e6723c6985399803a364848891513cc.
Backport of 2b1242abb3989f5d74e787b09132d01bcbee5b55 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:8>

Django

unread,
Jan 26, 2023, 3:36:24 AM1/26/23
to django-...@googlegroups.com
#34291: Validation of UniqueConstraint with ordered expressions crashes.
-------------------------------------+-------------------------------------
Reporter: Dan F | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"26b7a25632e7fe0b897bc9b88b5c364a4b6398b6" 26b7a25]:
{{{
#!CommitTicketReference repository=""
revision="26b7a25632e7fe0b897bc9b88b5c364a4b6398b6"
[4.1.x] Fixed #34291 -- Fixed Meta.constraints validation crash on
UniqueConstraint with ordered expressions.

Thanks Dan F for the report.

Bug in 667105877e6723c6985399803a364848891513cc.

Backport of 2b1242abb3989f5d74e787b09132d01bcbee5b55 from main.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34291#comment:9>

Reply all
Reply to author
Forward
0 new messages